-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add POST-endpoint to filter on IDs #39
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 45.56% 47.34% +1.77%
==========================================
Files 24 24
Lines 801 885 +84
==========================================
+ Hits 365 419 +54
- Misses 376 388 +12
- Partials 60 78 +18 ☔ View full report in Codecov by Sentry. |
19dccc0
to
2ea257e
Compare
2ea257e
to
6e251de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ser bra ut! Stemmer for generalisering av funksjoner/handlers som er like. Evt lage nytt issue i tekniske forbedringer boardet, sånn at vi har oversikt over forbedringspotensialer. Kanskje mange av de Get-metodene kan også tas i samme sleng, f.eks. ved å sende inn ressursnavn (enum) som parameter til handler.GetResource(ResourceType.Concept)
?! :)
e.GET(env.PathValues.Concepts, handlers.GetConcepts()) |
som jeg svarte Terje, det blir utenfor scope av dette issuet. Jeg lagde dette for å se nærmere på muligheten til å generalisere handler-metodene: #40 |
resolve #37