Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add POST-endpoint to filter on IDs #39

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Conversation

NilsOveTen
Copy link
Contributor

resolve #37

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 72.22222% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 47.34%. Comparing base (50a5605) to head (6e251de).

Files Patch % Lines
handlers/concept_handlers.go 64.28% 2 Missing and 3 partials ⚠️
handlers/data_service_handlers.go 64.28% 2 Missing and 3 partials ⚠️
handlers/dataset_handlers.go 64.28% 2 Missing and 3 partials ⚠️
handlers/event_handlers.go 64.28% 2 Missing and 3 partials ⚠️
handlers/information_model_handlers.go 64.28% 2 Missing and 3 partials ⚠️
handlers/service_handlers.go 64.28% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   45.56%   47.34%   +1.77%     
==========================================
  Files          24       24              
  Lines         801      885      +84     
==========================================
+ Hits          365      419      +54     
- Misses        376      388      +12     
- Partials       60       78      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NilsOveTen NilsOveTen force-pushed the feat/not/filter-on-ids branch from 19dccc0 to 2ea257e Compare March 26, 2024 11:49
@NilsOveTen NilsOveTen force-pushed the feat/not/filter-on-ids branch from 2ea257e to 6e251de Compare March 26, 2024 11:52
@NilsOveTen NilsOveTen requested a review from terjesyl April 2, 2024 13:19
Copy link

@pooriamehregan pooriamehregan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser bra ut! Stemmer for generalisering av funksjoner/handlers som er like. Evt lage nytt issue i tekniske forbedringer boardet, sånn at vi har oversikt over forbedringspotensialer. Kanskje mange av de Get-metodene kan også tas i samme sleng, f.eks. ved å sende inn ressursnavn (enum) som parameter til handler.GetResource(ResourceType.Concept)?! :)

e.GET(env.PathValues.Concepts, handlers.GetConcepts())

@NilsOveTen
Copy link
Contributor Author

Ser bra ut! Stemmer for generalisering av funksjoner/handlers som er like. Evt lage nytt issue i tekniske forbedringer boardet, sånn at vi har oversikt over forbedringspotensialer. Kanskje mange av de Get-metodene kan også tas i samme sleng, f.eks. ved å sende inn ressursnavn (enum) som parameter til handler.GetResource(ResourceType.Concept)?! :)

e.GET(env.PathValues.Concepts, handlers.GetConcepts())

som jeg svarte Terje, det blir utenfor scope av dette issuet. Jeg lagde dette for å se nærmere på muligheten til å generalisere handler-metodene: #40

@NilsOveTen NilsOveTen merged commit 7452aaf into main Apr 3, 2024
5 checks passed
@NilsOveTen NilsOveTen deleted the feat/not/filter-on-ids branch April 3, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mulighet for å filtrere liste-endepunktene basert på liste med fdkId
3 participants