This repository has been archived by the owner on Dec 10, 2024. It is now read-only.
Upgrade dependencies - Mockito, Slf4j, Spotbugs, sonar-source etc #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitojduggal
changed the title
|
@TobiX Can you please have a look at this one?, seems fine with the tests. we can simply close other open MRs for dependency upgrades |
|
You probably need to raise the minimum required Java version in the CI matrix first. |
TobiX
reviewed
Dec 26, 2023
| @@ -98,7 +98,7 @@ | |||
| <dependency> | |||
| <groupId>org.codenarc</groupId> | |||
| <artifactId>CodeNarc</artifactId> | |||
| <version>2.2.0</version> | |||
| <version>3.3.0</version> | |||
There was a problem hiding this comment.
When updating CodeNarc, you should update the external at the same time and use the codenarc-converter to integrate changes in codenarc rules into this plugin
There was a problem hiding this comment.
Thanks for the quick response Tobi, i will do so.
There was a problem hiding this comment.
Done @TobiX , the build seems to go through.
added 6 commits
December 27, 2023 10:06
Done, made 11 as minimum |
|
@TobiX shall we merge this one? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating dependencies- Mockito, Slf4j, Spotbugs, sonar-source etc