fest: defer webhook event loads to prevent panics

routes/staff/endpoints/get_full_app_list/route.go

@@ -24,16 +24,8 @@ func Docs() *docs.Doc {
 	return &docs.Doc{
 		Summary:     "Staff: Get Full Application List",
 		Description: "Gets all applications of a user returning a list of apps.",
-		Params: []docs.Parameter{
-			{
-				Name:        "user_id",
-				Description: "The ID of the user to use.",
-				Required:    true,
-				In:          "path",
-				Schema:      docs.IdSchema,
-			},
-		},
-		Resp: types.AppListResponse{},
+		Params:      []docs.Parameter{},
+		Resp:        types.AppListResponse{},
 	}
 }
 

webhooks/events/events.go

@@ -3,12 +3,14 @@ package events
 import (
 	"fmt"
 	"os"
+	"popplio/state"
 	"popplio/types"
 	"reflect"
 
 	"github.com/bwmarrin/discordgo"
 	docs "github.com/infinitybotlist/eureka/doclib"
 	"github.com/infinitybotlist/eureka/dovewing/dovetypes"
+	"go.uber.org/zap"
 )
 
 type EventRegistry struct {
@@ -27,7 +29,26 @@ type WebhookEvent interface {
 	Description() string
 }
 
+var eventList = []WebhookEvent{}
+
+// Adds an event to be registered. This should be called in the init() function of the event
+//
+// Note that this function does not register the event, it just adds it to the list of events to be registered.
+// This is because `doclib` and `state` are not initialized until after state setyp
 func RegisterEvent(a WebhookEvent) {
+	eventList = append(eventList, a)
+}
+
+// Register all events
+func RegisterAllEvents() {
+	for _, a := range eventList {
+		state.Logger.Error("Webhook event register", zap.String("event", a.Event()))
+		registerEventImpl(a)
+	}
+}
+
+// Internal implementation to register an event
+func registerEventImpl(a WebhookEvent) {
 	docs.AddWebhook(&docs.WebhookDoc{
 		Name:    a.Event(),
 		Summary: a.Summary(),

webhooks/setup.go

@@ -3,6 +3,7 @@ package webhooks
 import (
 	"popplio/webhooks/bothooks"
 	"popplio/webhooks/bothooks_legacy"
+	"popplio/webhooks/events"
 	"popplio/webhooks/sender"
 	"popplio/webhooks/serverhooks"
 	"popplio/webhooks/teamhooks"
@@ -33,6 +34,8 @@ func Setup() {
 		"Webhooks are a way to receive events from Infinity Bot List in real time. You can use webhooks to receive events such as new votes, new reviews, and more.",
 	)
 
+	events.RegisterAllEvents()
+
 	for _, driver := range RegisteredDrivers {
 		driver.Register()