Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing validation for signatures around Mitre Tactics, Techniques, … #499

Open
wants to merge 1 commit into
base: rc
Choose a base branch
from
Open

Removing validation for signatures around Mitre Tactics, Techniques, … #499

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions app/routes/yara_rules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,17 +386,8 @@ def create_yara_rule():
active=request.json.get("active", True)
)

mitre_techniques = Cfg_settings.get_setting("MITRE_TECHNIQUES").split(",")
entity.mitre_techniques = request.json.get("mitre_techniques", [])
matches = [technique for technique in entity.mitre_techniques if technique not in mitre_techniques]
if matches:
raise Exception

mitre_tactics = Cfg_settings.get_setting("MITRE_TACTICS").split(",")
entity.mitre_tactics = request.json.get("mitre_tactics", [])
matches = [tactic for tactic in entity.mitre_tactics if tactic not in mitre_tactics]
if matches:
raise Exception

if entity.state == release_state:
entity.state = draft_state.state
Expand Down Expand Up @@ -557,23 +548,9 @@ def update_yara_rule(id):
active=request.json.get("active", entity.active)
)

mitre_techniques = Cfg_settings.get_setting("MITRE_TECHNIQUES").split(",")
entity.mitre_techniques = request.json.get("mitre_techniques", [])
matches = [technique for technique in entity.mitre_techniques if technique not in mitre_techniques]
if matches:
raise Exception

mitre_sub_techniques = Cfg_settings.get_setting("MITRE_SUB_TECHNIQUES").split(",")
entity.mitre_sub_techniques = request.json.get("mitre_sub_techniques", [])
matches = [technique for technique in entity.mitre_sub_techniques if technique not in mitre_sub_techniques]
if matches:
raise Exception

mitre_tactics = Cfg_settings.get_setting("MITRE_TACTICS").split(",")
entity.mitre_tactics = request.json.get("mitre_tactics", [])
matches = [tactic for tactic in entity.mitre_tactics if tactic not in mitre_tactics]
if matches:
raise Exception

if old_state == release_state.state and entity.state == release_state.state and not do_not_bump_revision:
entity.state = draft_state.state
Expand Down