Add Meziantou.Analyzers (#160)

.editorconfig

@@ -306,3 +306,13 @@ dotnet_diagnostic.CA2000.severity = error               # CA2000: Dispose object
 dotnet_diagnostic.CA1515.severity = none                # CA1515: Consider making public types internal
 dotnet_diagnostic.CA1708.severity = none                # CA1708: Identifiers should differ by more than case
 dotnet_diagnostic.CA1716.severity = none                # CA1716: Identifiers should not match keywords
+
+MA0053.public_class_should_be_sealed = true
+MA0053.exceptions_should_be_sealed = true
+
+dotnet_diagnostic.MA0004.severity = none
+dotnet_diagnostic.MA0023.severity = none
+dotnet_diagnostic.MA0048.severity = none
+dotnet_diagnostic.MA0051.severity = none
+dotnet_diagnostic.MA0053.severity = warning
+dotnet_diagnostic.MA0071.severity = none

Directory.Packages.props

@@ -34,4 +34,8 @@
 	<PackageVersion Include="Verify.TUnit" Version="28.9.0" />
 	<PackageVersion Include="xunit.v3.assert" Version="1.0.1" />
   </ItemGroup>
+
+  <ItemGroup>
+	<GlobalPackageReference Include="Meziantou.Analyzer" Version="2.0.186" />
+  </ItemGroup>
 </Project>

src/Common/ITypeSymbolExtensions.cs

@@ -53,21 +53,15 @@ public static IEnumerable<ITypeSymbol> GetBaseTypesAndThis(this ITypeSymbol? typ
 		}
 	}
 
-	public static IEnumerable<ISymbol> GetAllMembers(this ITypeSymbol type)
-	{
-		if (type is { TypeKind: TypeKind.Interface })
-		{
-			return type.AllInterfaces
+	public static IEnumerable<ISymbol> GetAllMembers(this ITypeSymbol type) =>
+		type is { TypeKind: TypeKind.Interface }
+			? type
+				.AllInterfaces
 				.SelectMany(i => i.GetMembers())
-				.Concat(type.GetMembers());
-		}
-		else
-		{
-			return type
+				.Concat(type.GetMembers())
+			: type
 				.GetBaseTypesAndThis()
 				.SelectMany(t => t.GetMembers());
-		}
-	}
 
 	public static bool IsValidateAttribute([NotNullWhen(returnValue: true)] this INamedTypeSymbol? typeSymbol) =>
 		typeSymbol is

src/Immediate.Validations.Analyzers/UnusedConstructorParameterSuppressor.cs

@@ -36,7 +36,8 @@ public override void ReportSuppressions(SuppressionAnalysisContext context)
 
 			if (symbol.BaseType.IsValidatorAttribute())
 			{
-				var suppression = SupportedSuppressions.First(s => s.SuppressedDiagnosticId == diagnostic.Id);
+				var suppression = SupportedSuppressions
+					.First(s => string.Equals(s.SuppressedDiagnosticId, diagnostic.Id, StringComparison.Ordinal));
 
 				context.ReportSuppression(
 					Suppression.Create(

src/Immediate.Validations.Analyzers/ValidateClassAnalyzer.cs

@@ -352,7 +352,9 @@ ITypeSymbol typeArgumentType
 					attributeProperties ??= attribute.AttributeClass!.GetMembers()
 						.OfType<IPropertySymbol>()
 						.ToList();
-					var property = attributeProperties.First(a => a.Name == name);
+
+					var property = attributeProperties
+						.First(a => string.Equals(a.Name, name, StringComparison.Ordinal));
 
 					ValidateArgument(
 						context,
@@ -370,7 +372,7 @@ ITypeSymbol typeArgumentType
 				{
 					for (var j = 0; j < attributeParameters.Length; j++)
 					{
-						if (attributeParameters[j].Name == name)
+						if (string.Equals(attributeParameters[j].Name, name, StringComparison.Ordinal))
 						{
 							ValidateArgument(
 								context,
@@ -422,12 +424,13 @@ List<ISymbol> members
 		if (!parameter.IsTargetTypeSymbol())
 			return;
 
-		var validateParameter = validateParameterSymbols.First(p => p.Name == parameter.Name);
+		var validateParameter = validateParameterSymbols
+			.First(p => string.Equals(p.Name, parameter.Name, StringComparison.Ordinal));
 
 		if (syntax.Expression.IsNameOfExpression(out var propertyName))
 		{
 			var member = members
-				.FirstOrDefault(p => p.Name == propertyName);
+				.Find(p => string.Equals(p.Name, propertyName, StringComparison.Ordinal));
 
 			if (member is null)
 			{

src/Immediate.Validations.Analyzers/ValidatorClassAnalyzer.cs

@@ -283,8 +283,7 @@ IMethodSymbol methodSymbol
 			.GetMembers()
 			.OfType<IPropertySymbol>()
 			.Where(p =>
-				p.Name != "Message"
-				&& !p.IsStatic
+				p is { Name: not "Message", IsStatic: false }
 			)
 			.Cast<ISymbol>()
 			.ToList();

src/Immediate.Validations.CodeFixes/AddAdditionalValidationsCodeRefactoringProvider.cs

@@ -9,7 +9,7 @@
 namespace Immediate.Validations.CodeFixes;
 
 [ExportCodeRefactoringProvider(LanguageNames.CSharp, Name = "Add AdditionalValidations Method")]
-public class AddAdditionalValidationsCodeRefactoringProvider : CodeRefactoringProvider
+public sealed class AddAdditionalValidationsCodeRefactoringProvider : CodeRefactoringProvider
 {
 	public override async Task ComputeRefactoringsAsync(CodeRefactoringContext context)
 	{

src/Immediate.Validations.CodeFixes/AddValidateMethodCodefixProvider.cs

@@ -11,7 +11,7 @@
 namespace Immediate.Validations.CodeFixes;
 
 [ExportCodeFixProvider(LanguageNames.CSharp)]
-public class AddValidateMethodCodefixProvider : CodeFixProvider
+public sealed class AddValidateMethodCodefixProvider : CodeFixProvider
 {
 	public sealed override ImmutableArray<string> FixableDiagnosticIds { get; } =
 		ImmutableArray.Create([DiagnosticIds.IV0001ValidateMethodMustExist]);

src/Immediate.Validations.CodeFixes/CorrectValidatePropertyReturnTypeCodefixProvider.cs

@@ -10,7 +10,7 @@
 namespace Immediate.Validations.CodeFixes;
 
 [ExportCodeFixProvider(LanguageNames.CSharp)]
-public class CorrectValidatePropertyReturnTypeCodefixProvider : CodeFixProvider
+public sealed class CorrectValidatePropertyReturnTypeCodefixProvider : CodeFixProvider
 {
 	public sealed override ImmutableArray<string> FixableDiagnosticIds { get; } =
 		ImmutableArray.Create([DiagnosticIds.IV0004ValidateMethodMustReturnValueTuple]);

src/Immediate.Validations.CodeFixes/MakeValidatePropertyMethodStaticCodefixProvider.cs

@@ -9,7 +9,7 @@
 namespace Immediate.Validations.CodeFixes;
 
 [ExportCodeFixProvider(LanguageNames.CSharp)]
-public class MakeValidatePropertyMethodStaticCodefixProvider : CodeFixProvider
+public sealed class MakeValidatePropertyMethodStaticCodefixProvider : CodeFixProvider
 {
 	public sealed override ImmutableArray<string> FixableDiagnosticIds { get; } =
 		ImmutableArray.Create([DiagnosticIds.IV0002ValidateMethodMustBeStatic]);

src/Immediate.Validations.Generators/Utility.cs

@@ -18,7 +18,12 @@ public static Template GetTemplate(string name)
 		return Template.Parse(reader.ReadToEnd());
 	}
 
-	private static readonly Regex s_toTitleCaseRegex = new(@"(?<=[^A-Z])([A-Z])");
+	private static readonly Regex s_toTitleCaseRegex =
+		new(
+			@"(?<=[^A-Z])([A-Z])",
+			RegexOptions.Compiled,
+			matchTimeout: TimeSpan.FromMilliseconds(10)
+		);
 
 	public static string ToTitleCase(this string pascalCase) =>
 		s_toTitleCaseRegex

src/Immediate.Validations.Generators/ValidateTargetTransformer.cs

@@ -194,7 +194,7 @@ ImmutableArray<AttributeData> attributes
 		var validateMessage = attributes
 			.FirstOrDefault(a => a.AttributeClass.IsNotNullAttribute())
 			?.NamedArguments
-			.FirstOrDefault(a => a.Key == "Message") is { Value: { Value: { } } value }
+			.FirstOrDefault(a => a.Key is "Message") is { Value: { Value: { } } value }
 			? value.ToCSharpString()
 			: null;
 
@@ -424,7 +424,8 @@ ITypeSymbol propertyType
 					attributeProperties ??= attribute.AttributeClass!.GetMembers()
 						.OfType<IPropertySymbol>()
 						.ToList();
-					var property = attributeProperties.First(a => a.Name == name);
+					var property = attributeProperties
+						.First(a => string.Equals(a.Name, name, StringComparison.Ordinal));
 
 					var parameterValue = BuildArgumentValue(
 						syntax,
@@ -441,7 +442,7 @@ ITypeSymbol propertyType
 				{
 					for (var j = 0; j < attributeParameters.Length; j++)
 					{
-						if (attributeParameters[j].Name == name)
+						if (string.Equals(attributeParameters[j].Name, name, StringComparison.Ordinal))
 						{
 							var parameterValue = BuildArgumentValue(
 								syntax,

src/Immediate.Validations.Shared/ExpressionEvaluator.cs

@@ -19,7 +19,7 @@ internal static class ExpressionEvaluator
 			NewArrayExpression nae => GetValueFromNewArray(nae),
 			UnaryExpression ue => GetValueFromUnary(ue),
 			null => null,
-			_ => throw new NotSupportedException(/* TODO: Error Message */),
+			_ => throw new NotSupportedException("Unknown ExpressionType. Report an issue on the Immediate.Validations repository."),
 		};
 
 	[SuppressMessage(
@@ -35,7 +35,7 @@ internal static class ExpressionEvaluator
 				null,
 				parameters: [
 					GetValue(be.Left),
-					GetValue(be.Right)
+					GetValue(be.Right),
 				]
 			);
 		}

src/Immediate.Validations.Shared/Localization/LocalizationDictionary.cs

@@ -1,6 +1,10 @@
-using Microsoft.Extensions.Localization;
+using Microsoft.Extensions.Localization;
 
 namespace Immediate.Validations.Shared.Localization;
 
 internal sealed class LocalizationDictionary(Dictionary<string, string> localizations)
-	: Dictionary<string, LocalizedString>(localizations.ToDictionary(x => x.Key, x => new LocalizedString(x.Key, x.Value)));
+	: Dictionary<string, LocalizedString>(
+		localizations
+			.Select(kvp => KeyValuePair.Create(kvp.Key, new LocalizedString(kvp.Key, kvp.Value))),
+		StringComparer.Ordinal
+	);

src/Immediate.Validations.Shared/Localization/ValidatorLocalizer.cs

@@ -5,11 +5,12 @@ namespace Immediate.Validations.Shared.Localization;
 
 internal sealed partial class ValidatorLocalizer : IStringLocalizer
 {
-	private static readonly Dictionary<string, Dictionary<string, LocalizedString>> s_localizations = new()
-	{
-		["en"] = En(),
-		["fr"] = Fr(),
-	};
+	private static readonly Dictionary<string, Dictionary<string, LocalizedString>> s_localizations =
+		new(StringComparer.Ordinal)
+		{
+			["en"] = En(),
+			["fr"] = Fr(),
+		};
 
 	public IEnumerable<LocalizedString> GetAllStrings(bool includeParentCultures)
 	{
@@ -29,7 +30,7 @@ public LocalizedString this[string name]
 			if (s_localizations[currentCulture].TryGetValue(name, out var value))
 				return value;
 
-			return new LocalizedString(name, name, true);
+			return new LocalizedString(name, name, resourceNotFound: true);
 		}
 	}
 

src/Immediate.Validations.Shared/Localization/ValidatorLocalizer.en.cs

@@ -7,7 +7,7 @@ internal sealed partial class ValidatorLocalizer : IStringLocalizer
 {
 	[ExcludeFromCodeCoverage]
 	private static Dictionary<string, LocalizedString> En() =>
-		new LocalizationDictionary(new()
+		new LocalizationDictionary(new(StringComparer.Ordinal)
 		{
 			[nameof(EmptyAttribute)] = "'{PropertyName}' must be empty.",
 			[nameof(EnumValueAttribute)] = "'{PropertyName}' has a range of values which does not include '{PropertyValue}'.",

src/Immediate.Validations.Shared/Localization/ValidatorLocalizer.fr.cs

@@ -7,7 +7,7 @@ internal sealed partial class ValidatorLocalizer : IStringLocalizer
 {
 	[ExcludeFromCodeCoverage]
 	private static Dictionary<string, LocalizedString> Fr() =>
-		new LocalizationDictionary(new()
+		new LocalizationDictionary(new(StringComparer.Ordinal)
 		{
 			[nameof(EmptyAttribute)] = "'{PropertyName}' doit être vide.",
 			[nameof(EnumValueAttribute)] = "'{PropertyName}' a une plage de valeurs qui n'inclut pas '{PropertyValue}'.",

src/Immediate.Validations.Shared/ValidationResult.cs

@@ -13,7 +13,7 @@ namespace Immediate.Validations.Shared;
 /// </summary>
 public sealed partial class ValidationResult : IEnumerable<ValidationError>
 {
-	[GeneratedRegex("{([^{}:]+)(?::([^{}]+))?}")]
+	[GeneratedRegex("{([^{}:]+)(?::([^{}]+))?}", RegexOptions.None, matchTimeoutMilliseconds: 50)]
 	private static partial Regex FormatRegex();
 
 	private List<ValidationError>? _errors;
@@ -81,6 +81,7 @@ IEnumerable<ValidationError> errors
 	/// <param name="arguments">
 	///	    The values which can be used with <paramref name="messageTemplate"/> to build the final validation message.
 	/// </param>
+	[SuppressMessage("Design", "MA0016:Prefer using collection abstraction instead of implementation")]
 	public void Add(
 		string propertyName,
 		string messageTemplate,
@@ -162,7 +163,7 @@ public void Add(
 
 		var message = overrideMessage ?? GetValidationMessage(method.DeclaringType);
 
-		var arguments = new Dictionary<string, object?>
+		var arguments = new Dictionary<string, object?>(StringComparer.OrdinalIgnoreCase)
 		{
 			["PropertyValue"] = argumentValues[0],
 			["PropertyName"] = GetMemberName(targetPropertyExpression, targetObject),
@@ -243,7 +244,7 @@ private enum MemberIndex { None = 0, Member, Index, Method }
 			_ => null,
 		};
 
-	[GeneratedRegex(@"(?<=[^A-Z])([A-Z])")]
+	[GeneratedRegex(@"(?<=[^A-Z])([A-Z])", RegexOptions.None, matchTimeoutMilliseconds: 10)]
 	private static partial Regex FirstCharInWord();
 
 	private static string GetMemberName(MemberInfo member)

src/Immediate.Validations.Shared/Validators/EmptyAttribute.cs

@@ -30,6 +30,6 @@ internal static bool IsEmpty<T>(T value) =>
 			null => true,
 			string s when string.IsNullOrWhiteSpace(s) => true,
 			ICollection { Count: 0 } => true,
-			_ => EqualityComparer<T>.Default.Equals(value, default)
+			_ => EqualityComparer<T>.Default.Equals(value, default),
 		};
 }

src/Immediate.Validations.Shared/Validators/MatchAttribute.cs

@@ -42,13 +42,14 @@ public static bool ValidateProperty(string target, Regex? regex = null, [StringS
 			if (expr is null)
 				ThrowInvalidArgumentsException();
 
-			regex = new Regex(expr);
+			regex = new Regex(expr, RegexOptions.None, TimeSpan.FromMilliseconds(100));
 		}
 
 		return regex.IsMatch(target);
 	}
 
 	[DoesNotReturn]
+	[SuppressMessage("Usage", "MA0015:Specify the parameter name in ArgumentException", Justification = "Argument Exception applies to multiple properties")]
 	private static void ThrowInvalidArgumentsException() =>
 		throw new ArgumentException("Both `regex` and `expr` are `null`. At least one must be provided.");
 

tests/Immediate.Validations.FunctionalTests/.editorconfig

@@ -1,3 +1,6 @@
 [*.cs]
 
 dotnet_diagnostic.CA1822.severity = none                # CA1822: Mark members as static
+
+dotnet_diagnostic.MA0009.severity = none
+dotnet_diagnostic.MA0016.severity = none

tests/Immediate.Validations.FunctionalTests/IntegrationTests/CollectionTests.cs

@@ -40,7 +40,7 @@ public void InvalidRecordNullProperty()
 				{
 					PropertyName = "Strings",
 					ErrorMessage = "'Strings' must not be null.",
-				}
+				},
 			],
 			errors
 		);
@@ -158,7 +158,7 @@ public void InvalidCommandNullProperty()
 				{
 					PropertyName = "Commands",
 					ErrorMessage = "'Commands' must not be null.",
-				}
+				},
 			],
 			errors
 		);

tests/Immediate.Validations.FunctionalTests/IntegrationTests/DuplicateTypeVisitTests.cs

@@ -2,7 +2,7 @@
 
 namespace Immediate.Validations.FunctionalTests.IntegrationTests;
 
-public partial class DuplicateTypeVisitTests
+public sealed partial class DuplicateTypeVisitTests
 {
 	[Validate]
 	public partial interface IBaseInterface : IValidationTarget<IBaseInterface>

tests/Immediate.Validations.FunctionalTests/IntegrationTests/InheritanceTests.cs

@@ -55,7 +55,7 @@ public void ShortIdHasErrors()
 				{
 					PropertyName = "Id",
 					ErrorMessage = "'Id' must be more than 4 characters.",
-				}
+				},
 			],
 			errors
 		);
@@ -78,7 +78,7 @@ public void EmptyDescriptionHasErrors()
 				{
 					PropertyName = "Description",
 					ErrorMessage = "'Description' must not be empty.",
-				}
+				},
 			],
 			errors
 		);

tests/Immediate.Validations.FunctionalTests/IntegrationTests/SkipSelfTests.cs

@@ -29,7 +29,7 @@ public void SkipSelfOperatesCorrectly()
 				{
 					PropertyName = nameof(BaseClass.BaseString),
 					ErrorMessage = "'Base String' must not be null.",
-				}
+				},
 			],
 			errors
 		);

tests/Immediate.Validations.FunctionalTests/IntegrationTests/StructTests.cs

@@ -39,7 +39,7 @@ public void InvalidRecordStructNullProperty()
 				{
 					PropertyName = "StringProperty",
 					ErrorMessage = "'String Property' must not be null.",
-				}
+				},
 			],
 			errors
 		);
@@ -68,7 +68,7 @@ public void InvalidStructNullProperty()
 				{
 					PropertyName = "StringProperty",
 					ErrorMessage = "'String Property' must not be null.",
-				}
+				},
 			],
 			errors
 		);