-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fine-tune RidgeClassifier example notebook #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering whether in the README the two fine-tuned classifiers couldn't be covered in the same section. It doesn't seem they are that different as an approach, and the purpose is certainly more or less the same, isn't it?
Merging into one section would also allow to remove the redundant pieces of text. And perhaps a further comment could be offered comparing between the Ridge Classifier and an SVM classifier?
And perhaps Sam would be most suited to review the notebook? @samuelstevens if you have a chance to do that we can assign you as a reviewer. |
Yes I am happy to review the notebook. |
Notebook looks good to me, very straightfoward and easy to read from top to bottom. Great example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Adds a notebook that trains a RidgeClassifier that predicts species based on image embeddings created by BioCLIP. The RidgeClassifier logic is simplified from init_svc() in https://github.com/samuelstevens/biobench by @samuelstevens. Part of issue #76. Co-authored-by: Samuel Stevens <samuel.robert.stevens@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
7242da1
to
f2bc7f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Adds a notebook that trains a RidgeClassifier that predicts species based on image embeddings created by BioCLIP. The RidgeClassifier logic is simplified from init_svc() in https://github.com/samuelstevens/biobench by @samuelstevens.
Part of issue #76.