Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fine-tune RidgeClassifier example notebook #79

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

johnbradley
Copy link
Collaborator

Adds a notebook that trains a RidgeClassifier that predicts species based on image embeddings created by BioCLIP. The RidgeClassifier logic is simplified from init_svc() in https://github.com/samuelstevens/biobench by @samuelstevens.

Part of issue #76.

@johnbradley johnbradley requested a review from Copilot January 10, 2025 16:37
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

docs/python-tutorial.md Outdated Show resolved Hide resolved
docs/python-tutorial.md Outdated Show resolved Hide resolved
Copy link
Member

@hlapp hlapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering whether in the README the two fine-tuned classifiers couldn't be covered in the same section. It doesn't seem they are that different as an approach, and the purpose is certainly more or less the same, isn't it?

Merging into one section would also allow to remove the redundant pieces of text. And perhaps a further comment could be offered comparing between the Ridge Classifier and an SVM classifier?

@hlapp
Copy link
Member

hlapp commented Jan 11, 2025

And perhaps Sam would be most suited to review the notebook? @samuelstevens if you have a chance to do that we can assign you as a reviewer.

@samuelstevens
Copy link
Contributor

Yes I am happy to review the notebook.

@samuelstevens
Copy link
Contributor

Notebook looks good to me, very straightfoward and easy to read from top to bottom. Great example.

Copy link
Member

@egrace479 egrace479 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Adds a notebook that trains a RidgeClassifier that predicts
species based on image embeddings created by BioCLIP. The
RidgeClassifier logic is simplified from init_svc() in
https://github.com/samuelstevens/biobench by @samuelstevens.

Part of issue #76.

Co-authored-by: Samuel Stevens <samuel.robert.stevens@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Member

@hlapp hlapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johnbradley johnbradley merged commit e3fc7ca into main Jan 23, 2025
2 checks passed
@johnbradley johnbradley deleted the fine-tune-ridge branch January 23, 2025 20:12
@johnbradley johnbradley mentioned this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants