From 26ccad561d40a05dbc6c982011360e9f348b5586 Mon Sep 17 00:00:00 2001
From: Kornel <kornel@geekhood.net>
Date: Tue, 26 Dec 2023 20:08:41 +0000
Subject: [PATCH] Clippy

---
 src/c_api.rs    | 2 +-
 src/denoise.rs  | 1 +
 src/gifsicle.rs | 4 ++--
 src/lib.rs      | 2 +-
 4 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/c_api.rs b/src/c_api.rs
index 9d945f6..fde6b36 100644
--- a/src/c_api.rs
+++ b/src/c_api.rs
@@ -108,7 +108,7 @@ pub struct GifskiHandleInternal {
 /// Returns a handle for the other functions, or `NULL` on error (if the settings are invalid).
 #[no_mangle]
 pub unsafe extern "C" fn gifski_new(settings: *const GifskiSettings) -> *const GifskiHandle {
-    let settings = if let Some(s) = settings.as_ref() {s} else {
+    let Some(settings) = settings.as_ref() else {
         return ptr::null_mut();
     };
     let s = Settings {
diff --git a/src/denoise.rs b/src/denoise.rs
index 2663128..b2b8a16 100644
--- a/src/denoise.rs
+++ b/src/denoise.rs
@@ -208,6 +208,7 @@ impl Acc {
                 };
                 // min == 0 may wipe pixels totally clear, so give them at least a second chance,
                 // if quality setting allows
+                #[allow(overlapping_range_endpoints)]
                 let min = match threshold {
                     0..=300 if self.stayed_for <= 3 => 1, // q >= 75
                     300..=500 if self.stayed_for <= 2 => 1,
diff --git a/src/gifsicle.rs b/src/gifsicle.rs
index b0b6eec..5b694a8 100644
--- a/src/gifsicle.rs
+++ b/src/gifsicle.rs
@@ -245,11 +245,11 @@ impl GiflossyWriter {
                     pal,
                     image,
                     max_diff: self.loss,
-                    best_node: px as NodeId,
+                    best_node: u16::from(px),
                     best_pos: pos + 1,
                     best_total_diff: 0,
                 };
-                l.lossy_node(pos + 1, px as NodeId, 0, RgbDiff { r: 0, g: 0, b: 0 }, );
+                l.lossy_node(pos + 1, u16::from(px), 0, RgbDiff { r: 0, g: 0, b: 0 }, );
                 run = l.best_pos - pos;
                 pos = l.best_pos;
                 let selected_node = &code_table.nodes[l.best_node as usize];
diff --git a/src/lib.rs b/src/lib.rs
index 41db052..c1f2d92 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -712,7 +712,7 @@ impl Writer {
                 debug_assert!(end_pts > 0.);
 
                 to_remap.send(QuantizeMessage {
-                    end_pts, image, importance_map, ordinal_frame_number, frame_index, dispose, first_frame_has_transparency, prev_frame_keeps
+                    ordinal_frame_number, frame_index, first_frame_has_transparency, image, importance_map, prev_frame_keeps, dispose, end_pts
                 })?;
 
                 frame_index += 1;