-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to download schema references #156
Conversation
@ferozed the integration tests are failing. There is a special gradle task for them that you should be able to run locally (if you have Docker installed). Also, after looking a bit in the confluent code I wonder if there are not an integrated way to do this directly when parsing the schema using `toNormalize before retrieving the schema ? |
Right... but this will only work for AVRO schemas? |
Yeah... so the integration tests are failing because the new config I added is a required value. Is there any way to make it optional? I tried using |
Ok... i kinda worked around it by putting the |
src/main/kotlin/com/github/imflog/schema/registry/tasks/download/DownloadSubjectExtension.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/github/imflog/schema/registry/tasks/download/DownloadTask.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/github/imflog/schema/registry/tasks/download/DownloadTaskAction.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/com/github/imflog/schema/registry/tasks/download/DownloadTaskActionTest.kt
Show resolved
Hide resolved
src/main/kotlin/com/github/imflog/schema/registry/tasks/download/DownloadTaskAction.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/github/imflog/schema/registry/tasks/download/DownloadTaskAction.kt
Outdated
Show resolved
Hide resolved
Starts to look good ! Also we should update the readme with the new parameter. |
LGTM ! I keep you posted when I found the time to do so. Thank you for the contribution 🙏 |
Added ability to download schema references.
A new configuration
downloadReferences: Boolean
was added toDownloadSchema
.When set to true, and the schema has references, the referenced schemas are also downloaded. This will allow POJO generation to succeed from schema with references.