Skip to content

Commit

Permalink
Merge pull request #10 from Igor-Palaguta/Carthage_Support
Browse files Browse the repository at this point in the history
Carthage support
  • Loading branch information
Igor-Palaguta authored Apr 15, 2020
2 parents 5b9555f + 0c01e41 commit d0d23c8
Show file tree
Hide file tree
Showing 36 changed files with 1,485 additions and 818 deletions.
6 changes: 4 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ Packages
# Bundler
.bundle

# Carthage
Carthage

# Cocoapods
Pods/
Example/YoutubeEngine.xcworkspace
Pods
2 changes: 1 addition & 1 deletion .swiftformat
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# file options
--exclude Example/Pods,.build,.swiftpm,.git,.swiftpm
--exclude Carthage,.build,.swiftpm,.git,.swiftpm

# format options
--indent 4
Expand Down
3 changes: 2 additions & 1 deletion .swiftlint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,8 @@ excluded:
- .git
- .build
- .swiftpm
- Example/Pods
- Pods
- Carthage

custom_rules:
tabs:
Expand Down
1 change: 1 addition & 0 deletions Cartfile
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
github "ReactiveCocoa/ReactiveSwift" ~> 6.0
3 changes: 3 additions & 0 deletions Cartfile.private
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
github "Quick/Nimble" ~> 8.0
github "AliSoftware/OHHTTPStubs" ~> 9.0
github "onevcat/Kingfisher" ~> 5.0
4 changes: 4 additions & 0 deletions Cartfile.resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
github "AliSoftware/OHHTTPStubs" "9.0.0"
github "Quick/Nimble" "v8.0.7"
github "ReactiveCocoa/ReactiveSwift" "6.2.1"
github "onevcat/Kingfisher" "5.13.4"
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import Foundation
import Kingfisher
import UIKit
import YoutubeEngine

final class ChannelCell: UITableViewCell {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import Foundation
import Kingfisher
import UIKit
import YoutubeEngine

final class PlaylistCell: UITableViewCell {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import Foundation
import Kingfisher
import UIKit
import YoutubeEngine

final class PlaylistItemCell: UITableViewCell {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ final class VideoCell: UITableViewCell {
didSet {
// swiftlint:disable:next force_unwrapping
let snippet = video.snippet!

thumbnailView.kf.setImage(with: ImageResource(downloadURL: snippet.defaultImage.url),
options: [.transition(.fade(0.3))])

Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,9 @@ final class ItemsViewController: UITableViewController {
destinationController.title = playlist.snippet!.title
destinationController.model.mutableProvider.value = AnyItemsProvider { token, limit in
let request: PlaylistItemRequest = .itemsFromPlaylist(withID: playlist.id,
requiredParts: [.snippet],
limit: limit,
pageToken: token)
requiredParts: [.snippet],
limit: limit,
pageToken: token)
return Engine.defaultEngine
.playlistItems(request)
.map { page in (page.items.map { .playlistItem($0) }, page.nextPageToken) }
Expand Down
File renamed without changes.
18 changes: 0 additions & 18 deletions Example/Podfile

This file was deleted.

55 changes: 0 additions & 55 deletions Example/Podfile.lock

This file was deleted.

679 changes: 0 additions & 679 deletions Example/YoutubeEngine.xcodeproj/project.pbxproj

This file was deleted.

10 changes: 0 additions & 10 deletions Example/YoutubeEngine.xcworkspace/contents.xcworkspacedata

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import UIKit
import YoutubeEngine

extension Engine {
#warning("Generate yout own api key https://developers.google.com/youtube/v3/getting-started")
#warning("Generate your own API key https://developers.google.com/youtube/v3/getting-started")
static let defaultEngine = Engine(
authorization: .key("AIzaSyBjLH-61v1oTcb_wQUcGAYIHmWSCj19Ss4"),
isLogEnabled: true
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,17 +36,17 @@ Supports Swift 5

Cocoapods
```ruby
pod "YoutubeEngine", :git => 'https://github.com/Igor-Palaguta/YoutubeEngine', :tag => '0.6.0'
pod "YoutubeEngine", :git => 'https://github.com/Igor-Palaguta/YoutubeEngine', :tag => '0.7.0'
```

Carthage
```ruby
github "Igor-Palaguta/YoutubeEngine" ~> 0.6.0
github "Igor-Palaguta/YoutubeEngine" ~> 0.7.0
```

SPM
```swift
.package(url: "https://github.com/Igor-Palaguta/YoutubeEngine", .upToNextMinor(from: "0.6.0"))
.package(url: "https://github.com/Igor-Palaguta/YoutubeEngine", .upToNextMinor(from: "0.7.0"))
```

## Implemented API
Expand Down
1 change: 1 addition & 0 deletions Source/YoutubeEngine/Data/Image.swift
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import CoreGraphics
import Foundation

public struct Image: Equatable {
Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion YoutubeEngine.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = 'YoutubeEngine'
s.version = '0.5.0'
s.version = '0.7.0'
s.summary = 'Swift ReactiveCocoa lib for Youtube api.'

s.description = <<-DESC
Expand Down
Loading

0 comments on commit d0d23c8

Please sign in to comment.