Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD roles/icingadb_redis/tasks/install_on_suse.yml #234

Conversation

johanneskastl
Copy link
Contributor

AFAIK adding the Suse installation requires the community.general.zypper module (even though the task says ansible.builtin.package).

Should I add a collections/requirements.yml or a line in the galaxy.yml to make this visible?

fix #232

Copy link

cla-bot bot commented Dec 7, 2023

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @johanneskastl

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@johanneskastl johanneskastl marked this pull request as draft December 7, 2023 12:56
@johanneskastl johanneskastl changed the title ADD roles/icingadb_redis/tasks/install_on_suse.yml WIP: ADD roles/icingadb_redis/tasks/install_on_suse.yml Dec 7, 2023
@johanneskastl johanneskastl force-pushed the 20231206_add_Suse_support_icingadb_redis_role branch from abbeaa6 to 5cc9c2e Compare December 17, 2023 16:44
Copy link

cla-bot bot commented Dec 17, 2023

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @johanneskastl

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@bobapple
Copy link
Member

@cla-bot check

@cla-bot cla-bot bot added the cla/signed label Dec 18, 2023
@johanneskastl
Copy link
Contributor Author

Should I add a collections/requirements.yml or a line in the galaxy.yml to make this visible?

Any opinions?

@johanneskastl johanneskastl marked this pull request as ready for review December 18, 2023 14:20
@johanneskastl johanneskastl changed the title WIP: ADD roles/icingadb_redis/tasks/install_on_suse.yml ADD roles/icingadb_redis/tasks/install_on_suse.yml Dec 18, 2023
@mkayontour
Copy link
Member

mkayontour commented Jan 5, 2024

Hi, happy new year and sorry for the late reply. To get some things going, I added some tests to run just the roles with default vars. Can you merge the current master and add a second job in the following workflow. Icingadb_redis

Then add a fragment as explained in the CONTRIBUTING GUIDE

Add a bit of documentation for the mentioned requirements, just add a new header before the installation section in getting-started

Many thanks for your contribution and for more to come! :)

@mkayontour mkayontour mentioned this pull request Jan 17, 2024
8 tasks
@mkayontour
Copy link
Member

Work continues in PR #273.

@mkayontour mkayontour closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display proper fail messages if OS not supported
3 participants