3678: Require timelog comment via settings #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -59,12 +59,14 @@ function () { | |||
| echo '<link rel="stylesheet" href="' . htmlspecialchars($timeTableStyle) . '"></link>'; | |||
| $userId = htmlspecialchars(session('userdata.id'), ENT_QUOTES, 'UTF-8'); | |||
| $ticketCacheExpiration = app()->make(Setting::class)->getSetting('itk-leantime-timetable.ticketCacheExpiration') ?: '1200'; | |||
| $requireTimeRegistrationComment = app()->make(Setting::class)->getSetting('itk-leantime-timetable.requireTimeRegistrationComment') ?: '0'; | |||
There was a problem hiding this comment.
is 0 a sane default? what does 0 mean?
There was a problem hiding this comment.
should '0' be a int perhaps?
There was a problem hiding this comment.
Not really any reason to save it as int, so i changed it to just use the provided string "1" or setting it to "0"
sinejespersen
requested changes
Jan 28, 2025
sinejespersen
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
#3678
Description
Timelog comment is not only required if the plugin setting for it is checked.
Screenshot of the result
N/A
Checklist
If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.
Additional comments or questions
If you have any further comments or questions for the reviewer please add them here.