🐛✨ [Frontend] Automatically pull latest frontend version (nocache) #7054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7054 +/- ##
=======================================
Coverage 87.57% 87.57%
=======================================
Files 1629 1629
Lines 63454 63454
Branches 2047 2047
=======================================
Hits 55569 55569
Misses 7549 7549
Partials 336 336
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
|
odeimaiz
requested review from
calys,
giancarloromeo,
GitHK,
pcrespov,
mguidon,
sanderegg and
matusdrobuliak66
odeimaiz
changed the title
|
💪 |
pcrespov
approved these changes
Jan 17, 2025
| print(f"Updating vcs_ref_client: {index_file_path}") | ||
| file.write(data) | ||
|
|
||
| boot_file_paths = _get_output_file_paths("boot.js") |
There was a problem hiding this comment.
TIP: if you would instead use pathlib.Path, your code would become more compact
from pathlib import Path
boot_file_paths: list[Path] = [] # assume we have this
for boot_file_path in boot_file_paths:
if boot_file_path.is_file():
print(f"Updating URL_PARAMETERS: {boot_file_path}")
boot_file_path.write_text(
boot_file_path.read_text().replace(
"addNoCacheParam : false",
"addNoCacheParam : true",
)
)and the same with all the operations to compose paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
There is currently a mechanism in place to detect whether the webserver has a different version of frontend compared to the one the user's browser has. If that's the case a "Reload" button, that requests the newest version, is shown to the users.
In order to figure out that the user's browser is actually using a cached (different) version, we compare the
vcsRefClientstamped in a configuration file (that can be cached) and thevcsRefClientthat is included in the response to the/app-summaryresource (which is NOT cached).When the user hits the oSparc's "Reload" button, what oSparc does is add a random query parameter to the cacheable resources, forcing the browser to pull the latest version.
But when the user hits browser's reload button, the old-cached version might be loaded, hence the oSparc's Reload button would show up again, bringing the user to an endless loop:
In the animation:
no-cache=random_numberquery parameter and force the pull of the newest version (2)In this PR, the application loading pieces were tuned after compilation, making this random query parameter always be present.
Related issue/s
closes #6697
How to test
Dev-ops checklist