Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ web-api: trashed resources include trashedBy with the primary GID of the user that trashed it #7052

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jan 16, 2025

What do these changes do?

ReDoc

Any resource that was trashed (so far projects, folders or workspace) includes when trashedAt: datetime and who trashedBy: UserID

Related issue/s

How to test

cd services/web/server
make install-dev
pytest -vv tests/unit/**/test_*trash*.py

Dev-ops

None

@pcrespov pcrespov self-assigned this Jan 16, 2025
@pcrespov pcrespov added this to the Singularity milestone Jan 16, 2025
@pcrespov pcrespov added the a:webserver issue related to the webserver service label Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 38.46154% with 40 lines in your changes missing coverage. Please review.

Project coverage is 69.80%. Comparing base (3d01781) to head (e738f9b).

❗ There is a different number of reports uploaded between BASE (3d01781) and HEAD (e738f9b). Click for more details.

HEAD has 26 uploads less than BASE
Flag BASE (3d01781) HEAD (e738f9b)
unittests 30 4
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7052       +/-   ##
===========================================
- Coverage   87.57%   69.80%   -17.77%     
===========================================
  Files        1629      738      -891     
  Lines       63454    33599    -29855     
  Branches     2047      274     -1773     
===========================================
- Hits        55569    23455    -32114     
- Misses       7549    10082     +2533     
+ Partials      336       62      -274     
Flag Coverage Δ *Carryforward flag
integrationtests 64.68% <38.46%> (+0.91%) ⬆️ Carriedforward from 6c1dcca
unittests 92.10% <ø> (+6.14%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.37% <ø> (-8.02%) ⬇️
agent 96.45% <ø> (ø)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog 90.66% <ø> (ø)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.58% <ø> (-12.73%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.59% <ø> (-0.16%) ⬇️
efs_guardian 90.46% <ø> (ø)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.23% <38.46%> (-26.72%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d01781...e738f9b. Read the comment docs.

@pcrespov pcrespov changed the title WIP: ✨ Is468/trashed by WIP: ✨ trashed resources include trashedBy with the primary GID of the user that trashed it Jan 17, 2025
@pcrespov pcrespov changed the title WIP: ✨ trashed resources include trashedBy with the primary GID of the user that trashed it WIP: ✨ web-api: trashed resources include trashedBy with the primary GID of the user that trashed it Jan 17, 2025
@pcrespov pcrespov changed the title WIP: ✨ web-api: trashed resources include trashedBy with the primary GID of the user that trashed it ✨ web-api: trashed resources include trashedBy with the primary GID of the user that trashed it Jan 17, 2025
@pcrespov pcrespov marked this pull request as ready for review January 17, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant