Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Upgrade playwright to latest version and fix checking of service readyness #7047

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Jan 16, 2025

What do these changes do?

  • upgraded playwright to latest and greates (1.49) that is compatible with newer headless mode of chromium
  • fixed issue where the check if a service is ready was done unauthenticated, therefore wrongly detecting a service as being ready (reproducible 100% times by running make test-s4l-anywhere)

⚠️ Do not use httpx in playwright tests. there is an api_context_manager that is authenticated automatically.

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the e2e Bugs found by or related to the end-2-end testing label Jan 16, 2025
@sanderegg sanderegg added this to the Singularity milestone Jan 16, 2025
@sanderegg sanderegg self-assigned this Jan 16, 2025
Copy link
Contributor

@giancarloromeo giancarloromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci 👌

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.52%. Comparing base (5a3ea20) to head (5886b75).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7047      +/-   ##
==========================================
+ Coverage   85.44%   86.52%   +1.08%     
==========================================
  Files        1651     1641      -10     
  Lines       64839    64513     -326     
  Branches     2043     2043              
==========================================
+ Hits        55399    55822     +423     
+ Misses       9105     8356     -749     
  Partials      335      335              
Flag Coverage Δ
integrationtests 63.46% <ø> (+<0.01%) ⬆️
unittests 85.96% <ø> (+1.59%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.49% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.58% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.27% <ø> (ø)
pkg_service_integration 70.02% <ø> (ø)
pkg_service_library 73.88% <ø> (ø)
pkg_settings_library 90.60% <ø> (ø)
pkg_simcore_sdk 85.38% <ø> (ø)
agent 96.45% <ø> (ø)
api_server 90.54% <ø> (ø)
autoscaling 96.09% <ø> (ø)
catalog 90.66% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 76.51% <ø> (+0.08%) ⬆️
director_v2 91.27% <ø> (ø)
dynamic_scheduler 97.20% <ø> (ø)
dynamic_sidecar 89.78% <ø> (+0.03%) ⬆️
efs_guardian 90.46% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.28% <ø> (-0.24%) ⬇️
storage 89.57% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 82.64% <ø> (+3.35%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a3ea20...5886b75. Read the comment docs.

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: I've checked and the tests in the dynamic-scheduler relying on playwright do not use httpx

@sanderegg sanderegg merged commit eac9d86 into ITISFoundation:master Jan 16, 2025
1 check failed
@sanderegg sanderegg deleted the bugfixes/upgrade-playwright branch January 16, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants