-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ Upgrade playwright to latest version and fix checking of service readyness #7047
⬆️ Upgrade playwright to latest version and fix checking of service readyness #7047
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merci 👌
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7047 +/- ##
==========================================
+ Coverage 85.44% 86.52% +1.08%
==========================================
Files 1651 1641 -10
Lines 64839 64513 -326
Branches 2043 2043
==========================================
+ Hits 55399 55822 +423
+ Misses 9105 8356 -749
Partials 335 335
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: I've checked and the tests in the dynamic-scheduler relying on playwright do not use httpx
Quality Gate passedIssues Measures |
What do these changes do?
make test-s4l-anywhere
)Related issue/s
How to test
Dev-ops checklist