Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Refactoring of project locking using decorator #7044

Open
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Jan 14, 2025

What do these changes do?

following #7020, this is using the provided decorator to lock projects

  • additional specialized decorator with_project_locked that replaces context manager lock_with_notification' and lock_project` that were flawed as described in the PR above
  • replaced repo-wide the usage of these context managers and removed from code

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added a:webserver issue related to the webserver service efs-guardian labels Jan 14, 2025
@sanderegg sanderegg added this to the Singularity milestone Jan 14, 2025
@sanderegg sanderegg self-assigned this Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 93.87755% with 6 lines in your changes missing coverage. Please review.

Project coverage is 87.66%. Comparing base (3d01781) to head (5c3bf1c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7044      +/-   ##
==========================================
+ Coverage   87.57%   87.66%   +0.09%     
==========================================
  Files        1629     1271     -358     
  Lines       63454    53617    -9837     
  Branches     2047     1010    -1037     
==========================================
- Hits        55569    47006    -8563     
+ Misses       7549     6416    -1133     
+ Partials      336      195     -141     
Flag Coverage Δ
integrationtests 64.81% <72.34%> (+1.04%) ⬆️
unittests 85.62% <85.71%> (-0.35%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 74.57% <97.56%> (+0.67%) ⬆️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.38% <ø> (ø)
agent 96.45% <ø> (ø)
api_server 90.54% <ø> (ø)
autoscaling 96.09% <ø> (ø)
catalog 90.66% <ø> (ø)
clusters_keeper 99.24% <100.00%> (-0.01%) ⬇️
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 76.42% <ø> (-0.09%) ⬇️
director_v2 91.29% <ø> (-0.02%) ⬇️
dynamic_scheduler 97.21% <ø> (ø)
dynamic_sidecar 89.78% <ø> (+0.03%) ⬆️
efs_guardian 90.53% <100.00%> (+0.06%) ⬆️
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.52% <ø> (+0.05%) ⬆️
storage 89.57% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 86.27% <89.36%> (+0.32%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d01781...5c3bf1c. Read the comment docs.

@sanderegg sanderegg force-pushed the bugfixes/redis-lock-failing3 branch 2 times, most recently from 3ae7bfa to bc5c1a1 Compare January 17, 2025 12:23
@sanderegg sanderegg force-pushed the bugfixes/redis-lock-failing3 branch from 844a93a to c81404e Compare January 17, 2025 12:34
@sanderegg sanderegg marked this pull request as ready for review January 17, 2025 12:34
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thanks a lot

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work. It totally payed back thinking carefully the exclusive decorators!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service efs-guardian
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants