-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Refactoring of project locking using decorator #7044
base: master
Are you sure you want to change the base?
🐛Refactoring of project locking using decorator #7044
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7044 +/- ##
==========================================
+ Coverage 87.57% 87.66% +0.09%
==========================================
Files 1629 1271 -358
Lines 63454 53617 -9837
Branches 2047 1010 -1037
==========================================
- Hits 55569 47006 -8563
+ Misses 7549 6416 -1133
+ Partials 336 195 -141
Continue to review full report in Codecov by Sentry.
|
3ae7bfa
to
bc5c1a1
Compare
844a93a
to
c81404e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Thanks a lot
services/web/server/src/simcore_service_webserver/exporter/_handlers.py
Outdated
Show resolved
Hide resolved
services/efs-guardian/src/simcore_service_efs_guardian/services/background_tasks.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/projects_api.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work. It totally payed back thinking carefully the exclusive decorators!
Quality Gate passedIssues Measures |
What do these changes do?
following #7020, this is using the provided decorator to lock projects
with_project_locked
that replaces context managerlock_with_notification' and
lock_project` that were flawed as described in the PR aboveRelated issue/s
How to test
Dev-ops checklist