Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 extend ooil to support depends_on keyword in overwrites #7041

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Jan 14, 2025

What do these changes do?

When building some services like https://github.com/ITISFoundation/ML-TensorFlow-application it is mandatory that certain build job are concluded before start. With the depends_on keyword it is now possible to do so.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Jan 14, 2025
@GitHK GitHK added this to the Singularity milestone Jan 14, 2025
@GitHK GitHK added t:maintenance Some planned maintenance work a:ooil integration-library or ooil t:enhancement Improvement or request on an existing feature labels Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 88.57143% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.96%. Comparing base (a9c4d54) to head (f7bf7eb).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7041      +/-   ##
==========================================
+ Coverage   86.93%   87.96%   +1.03%     
==========================================
  Files        1651     1310     -341     
  Lines       64740    55253    -9487     
  Branches     2035      903    -1132     
==========================================
- Hits        56283    48606    -7677     
+ Misses       8122     6510    -1612     
+ Partials      335      137     -198     
Flag Coverage Δ
integrationtests 64.44% <ø> (-3.50%) ⬇️
unittests 86.81% <88.57%> (+1.50%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.48% <100.00%> (-0.06%) ⬇️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.18% <87.50%> (+0.15%) ⬆️
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.38% <ø> (ø)
agent 96.45% <ø> (ø)
api_server 90.54% <ø> (ø)
autoscaling 96.09% <ø> (ø)
catalog 90.66% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter ∅ <ø> (∅)
director 76.51% <ø> (ø)
director_v2 91.31% <ø> (ø)
dynamic_scheduler 97.20% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.46% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.52% <ø> (+0.23%) ⬆️
storage 89.57% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 84.13% <ø> (+0.07%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9c4d54...f7bf7eb. Read the comment docs.

@GitHK GitHK marked this pull request as ready for review January 15, 2025 12:53
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx.

@GitHK GitHK enabled auto-merge (squash) January 15, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:ooil integration-library or ooil t:enhancement Improvement or request on an existing feature t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants