-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Introduce wallet exchange 🗃️ #7033
✨ Introduce wallet exchange 🗃️ #7033
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7033 +/- ##
==========================================
- Coverage 87.56% 87.49% -0.07%
==========================================
Files 1629 1574 -55
Lines 63454 62085 -1369
Branches 2047 1794 -253
==========================================
- Hits 55566 54324 -1242
+ Misses 7552 7450 -102
+ Partials 336 311 -25
Continue to review full report in Codecov by Sentry.
|
….com:matusdrobuliak66/osparc-simcore into changing-wallet-after-running-out-of-credits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, but the change in the efs-guardian. I would like to discuss this.
...ervice-library/src/servicelib/rabbitmq/rpc_interfaces/resource_usage_tracker/service_runs.py
Show resolved
Hide resolved
services/efs-guardian/src/simcore_service_efs_guardian/services/background_tasks.py
Show resolved
Hide resolved
...ge-tracker/src/simcore_service_resource_usage_tracker/services/modules/db/service_runs_db.py
Show resolved
Hide resolved
...ge-tracker/src/simcore_service_resource_usage_tracker/services/modules/db/service_runs_db.py
Show resolved
Hide resolved
services/resource-usage-tracker/tests/unit/with_dbs/test_api_credit_transactions.py
Show resolved
Hide resolved
services/resource-usage-tracker/tests/unit/with_dbs/test_api_credit_transactions.py
Outdated
Show resolved
Hide resolved
...ces/resource-usage-tracker/tests/unit/with_dbs/test_process_rabbitmq_message_with_billing.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_states_handlers.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_wallets_handlers.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good from my side. Thanks a lot for the effort!
….com:matusdrobuliak66/osparc-simcore into changing-wallet-after-running-out-of-credits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Quality Gate passedIssues Measures |
What do these changes do?
Currently, a project's connected wallet can go into a negative balance. This occurs because we have a policy to avoid interrupting users' computational jobs when their wallet reaches 0 credits—only dynamic services are stopped.
This PR:
Example:
The project transaction is in debt:
After the user pays off the debt using another wallet (triggering 2 new transactions between the wallets), the project transaction status changes from IN_DEBT to BILLED, unblocking the project.
Related issue/s
How to test
Dev-ops checklist