♻️ web-server: preparation of trash plugin ⚠️

[pcrespov]

What do these changes do?

Preparations to add new features to the trash domain at the web-server. This action requires first some refactoring first to comply with the Controller-Service-Repository (CSR) layer and the naming conventions for action timestamps in the database columns.

🗃️ changes in database

• unifies naming for trash columns in projects, workspaces and folders tables
• renames trashed_at to trashed in order to follow convention in the database tables
  • NOTE: that the web-api trashedAt maps the database column trashed !
• adds trashed_by to projects table to track user

♻️ webserver

• creates plugin/domain for trash
  • Renamed PROJECT_TRASH_RETENTION_DAYS as TRASH_RETENTION_DAYS
• renames folders modules to follow CSR layers
• renames workspaces modules to follow CSR layers
• fixes dependencies between models (i.e. api-schemas know about domain models but not the other way around)
• adapts projects fixtures to new naming changes

Related issue/s

• part of Feature to undo a delete - "recycle bin" style osparc-issues#468
• added operation in tear-down to unblock flaky webserver 02 unit tests times-out #7008 (but still some issue with context managers that we need to understand!)

How to test

cd services/web/server
make install-dev
pytest -vv --pdb --ff tests/unit/**/test_*project*.py
pytest -vv --pdb --ff tests/unit/**/test_*trash*.py

Dev-ops ⚠️

• Renamed PROJECT_TRASH_RETENTION_DAYS to TRASH_RETENTION_DAYS
• repo.config adapted this osparc-config MR
• ⚠️ when this PR reaches production, we can completely remove PROJECT_TRASH_RETENTION_DAYS from all deploys

[codecov]

Codecov Report

Attention: Patch coverage is 87.01299% with 40 lines in your changes missing coverage. Please review.

Project coverage is 86.39%. Comparing base (79d19bf) to head (a639ad0).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7018      +/-   ##
==========================================
- Coverage   86.94%   86.39%   -0.55%     
==========================================
  Files        1651     1664      +13     
  Lines       64840    65036     +196     
  Branches     2043     2091      +48     
==========================================
- Hits        56373    56191     -182     
- Misses       8132     8497     +365     
- Partials      335      348      +13     

Flag	Coverage Δ
integrationtests	64.84% <56.43%> (-3.07%)	⬇️
unittests	84.71% <83.76%> (-0.61%)	⬇️

Components	Coverage Δ
api	76.84% <ø> (ø)
pkg_aws_library	93.49% <ø> (ø)
pkg_dask_task_models_library	97.09% <ø> (ø)
pkg_models_library	91.48% <92.10%> (-0.11%)	⬇️
pkg_notifications_library	84.57% <ø> (ø)
pkg_postgres_database	88.29% <100.00%> (+0.01%)	⬆️
pkg_service_integration	70.02% <ø> (ø)
pkg_service_library	73.89% <ø> (ø)
pkg_settings_library	90.60% <ø> (ø)
pkg_simcore_sdk	85.38% <ø> (ø)
agent	96.45% <ø> (ø)
api_server	90.54% <ø> (ø)
autoscaling	96.09% <ø> (ø)
catalog	90.66% <ø> (ø)
clusters_keeper	99.24% <ø> (ø)
dask_sidecar	91.26% <ø> (ø)
datcore_adapter	93.18% <ø> (ø)
director	76.51% <ø> (ø)
director_v2	91.31% <ø> (ø)
dynamic_scheduler	97.20% <ø> (ø)
dynamic_sidecar	89.75% <ø> (ø)
efs_guardian	90.46% <ø> (ø)
invitations	93.44% <ø> (ø)
osparc_gateway_server	∅ <ø> (∅)
payments	92.66% <ø> (ø)
resource_usage_tracker	89.34% <ø> (+0.05%)	⬆️
storage	89.57% <ø> (ø)
webclient	∅ <ø> (∅)
webserver	82.69% <86.36%> (-1.38%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79d19bf...a639ad0. Read the comment docs.

[YuryHrytsuk]

@pcrespov shall we already create a PR deleting PROJECT_TRASH_RETENTION_DAYS?

Or how not to forget to do that?

[mrnicegyu11]

Approving quickly to unblock without reading the whole PR, I had a look at the .env-devel, dev-ops-related-stuff, it all looks perfectly complete. Thanks a lot for also making the ops-config PR yourself in a very nice manner! < 3

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.8% Duplication on New Code

See analysis details on SonarQube Cloud