Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [Frontend] Trash bin #6590

Merged
merged 123 commits into from
Nov 29, 2024
Merged

✨ [Frontend] Trash bin #6590

merged 123 commits into from
Nov 29, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 24, 2024 •
edited
Loading

What do these changes do?

This PR implements the frontend part of the Trash bin.

Trash

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Oct 24, 2024
@odeimaiz odeimaiz changed the title ✨ [Frontend] Trash bin ✨ [Frontend] Recycle bin Oct 24, 2024
@odeimaiz odeimaiz changed the title ✨ [Frontend] Recycle bin ✨ [Frontend] Trash bin Oct 24, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Oct 24, 2024
@odeimaiz odeimaiz added this to the MartinKippenberger milestone Oct 24, 2024
@pcrespov pcrespov mentioned this pull request Nov 27, 2024
Merged
@pcrespov
Copy link
Member

Would it be possible to add a flag that hides all trash functionality until the backend is ready. e.g.

In this case it isn't just about hiding the feature, but changing the behaviour of many operations. I would rather not to go for the flag approach... I guess your main concern is trash collecting, right? We could just go for a 30 days keep-in-trash time and this could give us more time (if necessary) to finish it. Let's discuss it in person.

Ah, i have just seen this message. OK, no problem. let's then follow up tomorrow.
In any case I had thisone ready since yesterday and pushed it today #6850

matusdrobuliak66
matusdrobuliak66 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

@pcrespov pcrespov mentioned this pull request Nov 28, 2024
Merged
@odeimaiz odeimaiz requested a review from pcrespov November 29, 2024 12:08
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@odeimaiz odeimaiz dismissed pcrespov’s stale review November 29, 2024 12:12

The flag was removed, thanks

@odeimaiz odeimaiz enabled auto-merge (squash) November 29, 2024 12:12
@odeimaiz odeimaiz merged commit 42476f3 into ITISFoundation:master Nov 29, 2024
52 checks passed
@odeimaiz odeimaiz deleted the feature/trash-bin branch November 29, 2024 13:18
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Dec 10, 2024
Closed
17 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
Open
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg left review comments

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@pcrespov pcrespov pcrespov approved these changes

@GitHK GitHK GitHK approved these changes

@jsaq007 jsaq007 jsaq007 approved these changes

@ignapas ignapas Awaiting requested review from ignapas ignapas is a code owner

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
Event Horizon
Development

Successfully merging this pull request may close these issues.
6 participants
@odeimaiz @jsaq007 @pcrespov @GitHK @sanderegg @matusdrobuliak66