Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/disable dark mode #110

Merged
merged 9 commits into from
Nov 7, 2023
Merged

Feature/disable dark mode #110

merged 9 commits into from
Nov 7, 2023

Conversation

treee97
Copy link
Collaborator

@treee97 treee97 commented Nov 6, 2023

Changes

  • DaisyUI light mode enabled in tailwind config file
  • Added custom class for :hover
  • Fixed major visual bugs with hover selector
  • This PR fixes [FE] Disable dark theme #105

@ghost
Copy link

ghost commented Nov 6, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@netlify Netlify
Copy link

netlify bot commented Nov 6, 2023 •
edited
Loading

✅ Deploy Preview for it-academy-landing ready!

Name Link
🔨 Latest commit a5898a6
🔍 Latest deploy log https://app.netlify.com/sites/it-academy-landing/deploys/654a385d59ad6e0008e22052
😎 Deploy Preview https://deploy-preview-110--it-academy-landing.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vicenlu vicenlu merged commit e00dd2d into develop Nov 7, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FE] Disable dark theme
2 participants
@treee97 @vicenlu