Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature#307 #371

Merged
merged 27 commits into from
Jun 11, 2024
Merged

Feature#307 #371

merged 27 commits into from
Jun 11, 2024

Conversation

Yul1b3th
Copy link
Collaborator

No description provided.

Yul1b3th and others added 27 commits June 5, 2024 09:56
@Yul1b3th
Implementa OnInit en StarterComponent para manejo del ciclo de vida d…
80c5103 
…el componente
@Yul1b3th
Refactorización del servicio StarterService
cfbefe9
@Yul1b3th
Refactorización del servicio StarterService
3ed0144
@Yul1b3th
Realizadas pruebas unitarias para el servicio StarterService en start…
96e4f32 
…er.service.spec.ts
@Yul1b3th
changes
ad8187c
@Yul1b3th
changes
a236b29
@Yul1b3th
Realizadas pruebas unitarias al componente StarterComponent
e1f3d3c
@Yul1b3th
Elimina la llamada a getAllChallenges en StarterComponent
7725bf0
@codenaud
Solucionar los errores de ESLINT y TEST de auth.service.ts y auth.ser…
c05cb87 
…vice.specs.ts
@codenaud
Resolved merge conflicts between feature#307 and feature#307a - comen…
9939065 
…tar ambos archivos en eslintignore
@codenaud
Solventar Sonar cloud problema con password: 'testPassword'
4738300
@codenaud
Nueva alternativa fallos SonarCloud credenciales de password 'hardcod…
f6536f5 
…eado'
@Yul1b3th
changes
a398478
@Yul1b3th
Merge branch 'feature#307y' into feature#307
10e072e
@Yul1b3th
Implementa OnInit en StarterComponent para manejo del ciclo de vida d…
bfb2cef 
…el componente
@Yul1b3th
Refactorización del servicio StarterService
650cc15
@Yul1b3th
Refactorización del servicio StarterService
5a89453
@Yul1b3th
Realizadas pruebas unitarias para el servicio StarterService en start…
c6390c2 
…er.service.spec.ts
@Yul1b3th
changes
45452b9
@Yul1b3th
changes
5345026
@Yul1b3th
Realizadas pruebas unitarias al componente StarterComponent
9550999
@Yul1b3th
Elimina la llamada a getAllChallenges en StarterComponent
94ed2dd
@codenaud @Yul1b3th
Solventar Sonar cloud problema con password: 'testPassword'
ff5f6e4
@codenaud @Yul1b3th
Nueva alternativa fallos SonarCloud credenciales de password 'hardcod…
eb3cb21 
…eado'
@Yul1b3th
changes
c0f284c
@Yul1b3th
Commit de los cambios locales en feature#307y
c779fa3
@Yul1b3th
Merge branch 'feature#307' of https://github.com/IT-Academy-BCN/ita-c…
72c037c 
…hallenges-frontend into feature#307
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
20.9% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@jonatanvicente jonatanvicente merged commit 21cd252 into develop Jun 11, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yul1b3th @jonatanvicente @codenaud