Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.54-RELEASE feature#214 #247

Closed
wants to merge 9 commits into from
Closed

2.0.54-RELEASE feature#214 #247

wants to merge 9 commits into from

Conversation

sacom14
Copy link
Collaborator

@sacom14 sacom14 commented Mar 11, 2024

update release number to 2.0.54-RELEASE

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
11.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@jonatanvicente
Copy link
Collaborator

jonatanvicente commented Mar 12, 2024

Se ha hecho buen trabajo, pero hay varias cosas que revisar:

  • Es necesario externalizar a environment.ts y environment.prod.ts los valores de variables de endpoints de backend. Esos ficheros de configuración no deben contener referencias dummy en los nombres aunque sus valores apunten a dummy en la fase de dev. El nombre corresponderá a la variable real. Además, hay que revisar que no haya discordancias en la denominación de variables de ambos ficheros o habrá problemas en la fase de packaging para deploy.
  • Es necesario revisar si las interfaces se externalizarán a una nueva localización: otras implementaciones las incluyen en los files. Si se externalizan, deben sacarse todas.
  • Es necesario renombrar el file dummy resourses.json por resources.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants