Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config Management Refactoring #454

Closed
jonatanvicente opened this issue Oct 28, 2024 · 0 comments · Fixed by #477
Closed

Config Management Refactoring #454

jonatanvicente opened this issue Oct 28, 2024 · 0 comments · Fixed by #477
Assignees
@PacMM79
Labels
enhancement New feature or request help wanted Extra attention is needed Level 1 Level 1 Refactoring Refactoring

Comments

@jonatanvicente
Copy link
Collaborator

jonatanvicente commented Oct 28, 2024 •
edited
Loading

Files that contain configuration are not identical (both environment.ts and environment.prod.ts).
It's necessary to review them. In addition, many variable names are confused (including SSO prefix, for example).
@jonatanvicente jonatanvicente converted this from a draft issue Oct 28, 2024
@jonatanvicente jonatanvicente added enhancement New feature or request help wanted Extra attention is needed Refactoring Refactoring Level 1 Level 1 labels Oct 28, 2024
@PacMM79 PacMM79 self-assigned this Oct 28, 2024
PacMM79 added a commit that referenced this issue Oct 31, 2024
@PacMM79
#454: Config Management Refactoring
bee1c82
@PacMM79 PacMM79 linked a pull request Oct 31, 2024 that will close this issue
#454: Config Management Refactoring #461
Closed
@PacMM79 PacMM79 removed a link to a pull request Nov 11, 2024
#454: Config Management Refactoring #461
Closed
@PacMM79 PacMM79 linked a pull request Nov 11, 2024 that will close this issue
Feature#454: Config Management Refactoring #477
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PacMM79 PacMM79

Labels
enhancement New feature or request help wanted Extra attention is needed Level 1 Level 1 Refactoring Refactoring
Projects
ITA Challenges - Frontend Sprint Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature#454: Config Management Refactoring IT-Academy-BCN/ita-challenges-frontend
2 participants
@jonatanvicente @PacMM79