Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Challenge Screen: Scroll doesn't work at the mobile version #436

Closed
xapolin1979 opened this issue Oct 16, 2024 · 0 comments · Fixed by #444
Closed

Challenge Screen: Scroll doesn't work at the mobile version #436

xapolin1979 opened this issue Oct 16, 2024 · 0 comments · Fixed by #444
Assignees
@PacMM79
Labels
bug Something isn't working Level 1 Level 1 Mobile Design Mobile Design

Comments

@xapolin1979
Copy link
Collaborator

xapolin1979 commented Oct 16, 2024 •
edited by jonatanvicente
Loading

At screen Challenge (where is the Challenge explanation, resources, etc), scroll doesn't work at the mobile version. See screenshot below.

NOTE: Footer must be always visible

Image
@xapolin1979 xapolin1979 added the Design Design label Oct 16, 2024
@jonatanvicente jonatanvicente added bug Something isn't working and removed bug Something isn't working labels Oct 16, 2024
@jonatanvicente jonatanvicente added Level 1 Level 1 Mobile Design Mobile Design labels Oct 16, 2024
PacMM79 added a commit that referenced this issue Oct 16, 2024
@PacMM79
#436: Fix Body Scroll
8479104 
- Drop height 100% and keep auto as default value.
- Drop overflow hidden from body.
- Decrease top padding as it causes unwanted movement in the left navigation column on desktop view.
- Drop bottom padding to follow Figma design.
PacMM79 added a commit that referenced this issue Oct 16, 2024
@PacMM79
#436: Mobile: Fix Scroll issue in Main Component 1/2
cf7334f 
- Drop height calculation from Main Component as its causing issues with scroll and hides bottom main content.
PacMM79 added a commit that referenced this issue Oct 16, 2024
@PacMM79
#436: Mobile: Fix Scroll issue in Main Component 2/2
2dbe1e9 
- Add Media Query with padding in Footer Component.
@jonatanvicente jonatanvicente added bug Something isn't working and removed Design Design labels Oct 17, 2024
@jonatanvicente jonatanvicente changed the title It doesn't work the scroll on the mobile version Challenge Screen: It doesn't work the scroll on the mobile version Oct 17, 2024
@jonatanvicente jonatanvicente changed the title Challenge Screen: It doesn't work the scroll on the mobile version Challenge Screen: Scroll doesn't work the scroll at the mobile version Oct 17, 2024
@jonatanvicente jonatanvicente changed the title Challenge Screen: Scroll doesn't work the scroll at the mobile version Challenge Screen: Scroll doesn't work at the mobile version Oct 17, 2024
@jonatanvicente jonatanvicente linked a pull request Oct 21, 2024 that will close this issue
#436c: Fix Body Scroll - Test #2 #444
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PacMM79 PacMM79

Labels
bug Something isn't working Level 1 Level 1 Mobile Design Mobile Design
Projects
ITA Challenges - Frontend Sprint Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#436c: Fix Body Scroll - Test #2 IT-Academy-BCN/ita-challenges-frontend
3 participants
@jonatanvicente @PacMM79 @xapolin1979