Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: Date Formatter isn't a service, is a pipe #396

Open
jonatanvicente opened this issue Jul 1, 2024 · 1 comment
Open

Refactoring: Date Formatter isn't a service, is a pipe #396

jonatanvicente opened this issue Jul 1, 2024 · 1 comment
Assignees
Labels
Level 1 Level 1

Comments

@jonatanvicente
Copy link
Collaborator

There is a service called date-formatter.service. Nevertheless, actions implemented on that are most appropriately on a pipe element.
In addition, there is a pipe called format-date.pipe (not implemented). Masks implemented should be located at this pipe.

@Yul1b3th
Copy link
Collaborator

Yul1b3th commented Jul 2, 2024

Al final no he utilizado el servicio date-formatter.service.ts ¿lo podemos eleminar?

Tampoco he utilizado format-date.pipe.ts ¿lo podemos eliminar?

el DatePipe tiene este sintaxis
{{ fecha | date: formato: timezone: locale }}

y he implemenatdo esto en el html
date:'mediumDate':'':currentLang

@Yul1b3th Yul1b3th moved this from Doing to Testing in ITA Challenges - Frontend Sprint Backlog Jul 2, 2024
@Yul1b3th Yul1b3th linked a pull request Jul 2, 2024 that will close this issue
@Yul1b3th Yul1b3th moved this from Doing to Testing in ITA Challenges - Frontend Sprint Backlog Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Level 1 Level 1
Projects
Development

Successfully merging a pull request may close this issue.

2 participants