WIP: GPHWPP-3655 Dashboard - NBA #76
Conversation
| * | ||
| * @return string | ||
| */ | ||
| public function get_title() { |
There was a problem hiding this comment.
Das könnte man auch mit Magic Gettern machen: https://www.php.net/manual/en/language.oop5.overloading.php#object.get Damit spart man sich alle Getter
There was a problem hiding this comment.
Even shorter using readonly classes / properties https://stitcher.io/blog/readonly-classes-in-php-82
There was a problem hiding this comment.
And please move the types from phpdoc comments to php - it's 2025 - we use PHP 8.3 🤓
BTW: From my opinion most multiline comments can be removed from the class properties if the types are declared in native PHP (=> no one needs the information that the description property contains the description, isn't it ?)
There was a problem hiding this comment.
Just an idea - why not locating the model in packages/wp-plugin/essentials/src/dashboard/blocks/next-best-actions/model.php ?
As long as the model only consists of one file, the directory around it is superfluous - think of KISS (https://en.wikipedia.org/wiki/KISS_principle). And i suspect there won't be many more models.
| * This class represents the Next Best Action (NBA) model. | ||
| */ | ||
|
|
||
| namespace ionos_wordpress\essentials\dashboard\blocks\next_best_actions\model; |
There was a problem hiding this comment.
why creating a namespace for just one class in just one file ?
As long as the model only consists of one file, the extra namespace around it is superfluous - think of KISS (https://en.wikipedia.org/wiki/KISS_principle). And i suspect there won't be many more models.
No description provided.