Skip to content

Commit

Permalink
fix: wf environment variables for GitHub
Browse files Browse the repository at this point in the history
  • Loading branch information
lgersman committed Nov 11, 2024
1 parent 4b08bc0 commit 4d3d2ee
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 7 deletions.
4 changes: 4 additions & 0 deletions .github/shared/actions/devcontainer-shell-run/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ runs:

- uses: devcontainers/ci@v0.3
id: devcontainer_shell_run
env:
# for some reason these default env vars are not available in the dev container by default
GITHUB_ACTIONS: true
CI: true
with:
push: never
cacheFrom: ${{ steps.image_name.outputs.image_name }}
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,6 @@ jobs:
id: build_project
with:
runCmd: |
# for some reason these default env vars are not available in the dev container by default
export GITHUB_ACTIONS=true
export CI=true
env
pnpm install --frozen-lockfile
echo "WP_ENV_HOME=${WP_ENV_HOME}"
Expand Down
6 changes: 3 additions & 3 deletions scripts/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@
# this script is used to build all packages of the monorepo
#

# bootstrap the environment
source "$(realpath $0 | xargs dirname)/includes/bootstrap.sh"

# skip building if BUILD_UP_TO_DATE is set to 1
if [[ "${BUILD_UP_TO_DATE:-}" == '1' ]]; then
ionos.wordpress.log_info "skip (re)building : BUILD_UP_TO_DATE=1"
exit 0
fi

# bootstrap the environment
source "$(realpath $0 | xargs dirname)/includes/bootstrap.sh"

# build a monorepo workspace package of type npm
#
# @param $1 path to workspace package directory
Expand Down
2 changes: 1 addition & 1 deletion scripts/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ source "$(realpath $0 | xargs dirname)/includes/bootstrap.sh"

#region execute storybook tests
# install playwright dependencies
([[ "$CI" == "1" ]] || [[ "$CI" == "true" ]]) && pnpm exec playwright install-deps
[[ -z $CI ]] && pnpm exec playwright install-deps

pnpm exec playwright test -c ./playwright-ct.config.js $@
#endregion
Expand Down

0 comments on commit 4d3d2ee

Please sign in to comment.