Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IO library fixes & improvements #109

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

FatsieFS
Copy link
Contributor

This PR contains critical fix for the IOPadVdd cell. Previous gds should not be used anymore for new tape-outs.
For the rest some small improvements to the generated files and docs.

@stafverhaegen-chipflow
Copy link
Contributor

@sergeiandreyev @KrzysztofHerman
Current CDL seems out of date. The IOPadVdd cell in the CDL still contains the ESD diodes and not the RC clamp.

@stafverhaegen-chipflow
Copy link
Contributor

BTW, this thus contain fix for #101
There is still a difference between gds I uploaded in that issue and the current gds. The former still contained a DRC with a connection with too big width on metal2.

@FatsieFS
Copy link
Contributor Author

I only now see that Boris did still find that the bulk is connected to iovdd; so wait with merging until this is clarified.

@sergeiandreyev
Copy link
Contributor

Hello Staf, let's have a sync-up on IO cells with Alexey Balashov, to be all on the same page
I guess we're going out of sync now..

@sergeiandreyev
Copy link
Contributor

@FatsieFS , we just had a meeting with Mabrains team who are developing KLayout LVS for our OpenPDK..
could you please take a look at the slides on IO cells, if all these items are known/fixed/could be waived
https://docs.google.com/presentation/d/19rNEkZFATAg9Ojm-7nIBbsLfwG7sHYNntAm3xROcy3c/edit?usp=sharing
Thank you in advance!

@dnltz
Copy link
Contributor

dnltz commented May 18, 2024

@FatsieFS IOPadVdd has missing slits on M2. Maximum width without slits is 30u.

* IOPadVdd: remove spurious diodes from netlist and update IOPadVdd
  internal connections in layout to fix reported problem.
  Previous layout did not have proper ESD on Vdd pin and also resulted in
  iovdd to iovss static current.
* Update performance simulation after fixing the diode model. Removes the
  NA values present in the result tables.
* Set LEF version to 5.7
* Fix indentation in dummy liberty file.

Signed-off-by: Staf Verhaegen <staf.verhaegen@chipflow.io>
@stafverhaegen-chipflow
Copy link
Contributor

@FatsieFS IOPadVdd has missing slits on M2. Maximum width without slits is 30u.

I updated patch with fixed gds. I did fix it but seems I did not properly update the gds file in the patch.
Also rebased the patch on top of latest dev branch.

@dnltz
Copy link
Contributor

dnltz commented May 21, 2024

@stafverhaegen-chipflow just tried your new GDS and looks good to me!

image

@KrzysztofHerman
Copy link
Contributor

@dnltz does it solve the problem for you? Shall we merge ?

@dnltz
Copy link
Contributor

dnltz commented May 21, 2024

@KrzysztofHerman Slt.c is missing in the Open PDK rules but there is no area wider then 30u anymore. Should be fine.

@KrzysztofHerman KrzysztofHerman merged commit 62f5e3e into IHP-GmbH:dev May 21, 2024
12 checks passed
@stafverhaegen-chipflow
Copy link
Contributor

@KrzysztofHerman
I think you can close #101 also then.
There may still be open questions about LVS as discussed in #109 (comment) but from our f2f discussion I understood Alexey would take the next steps there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants