-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent notebooks from being executed on ReadTheDocs build #122
Conversation
@TimBartholomew @AlexNoring if you have a second, please verify that the issue you reported (#115 and #121 respectively) are resolved by this PR. You can use the following link for a preview build: https://idaes-examples--122.org.readthedocs.build/en/122/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
My only question is what the warning messages about the Helmholtz functions in one of the new outputs were (in case there was something there that needed to be addressed). Unfortunately the output got cut off in the screenshot.
@andrewlee94 you should be able to browse the preview build for the section corresponding to that screenshot: https://idaes-examples--122.org.readthedocs.build/en/122/active/power_gen/ngcc/ngcc_doc.html#create-the-ngcc-model Would it make sense to create a dedicated issue to track that? |
OK - that is not something to fix here. I think @JavalVyas2000 is already working on fixing this in another PR. |
@andrewlee94, I am working on the NGCC example and subsequently on the Helmholtz functions EoS warnings as well. |
@lbianchi-lbl Yes, this resolves issue #121. |
.readthedocs.yaml
caused the notebooks to be executed on the ReadTheDocs runner prior to the HTML build taking placeidaes get-extensions
)#115 Before
#115 After
#121 Before
#121 After
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution:
📚 Documentation preview 📚: https://idaes-examples--122.org.readthedocs.build/en/122/