Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select: fix ModelHash incorrect typing in SacessMinimizeMethod #1548

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

dilpath
Copy link
Member

@dilpath dilpath commented Jan 22, 2025

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.33%. Comparing base (c0339bb) to head (e0a902c).

Files with missing lines Patch % Lines
pypesto/select/misc.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1548      +/-   ##
===========================================
- Coverage    84.36%   84.33%   -0.03%     
===========================================
  Files          163      163              
  Lines        13987    13987              
===========================================
- Hits         11800    11796       -4     
- Misses        2187     2191       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@PaulJonasJost PaulJonasJost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the docstring and the fix

@dilpath
Copy link
Member Author

dilpath commented Jan 22, 2025

Will merge after @vwiela confirms this fixes the issue he saw.

@vwiela
Copy link
Contributor

vwiela commented Jan 22, 2025

Fixes the issue, thanks for updating.

@dilpath dilpath added this pull request to the merge queue Jan 22, 2025
Merged via the queue into develop with commit 109bec9 Jan 22, 2025
18 checks passed
@FFroehlich FFroehlich deleted the fix_select_sacess_hash branch January 23, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants