Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SciPy 1.15 compatibility #1544

Merged
merged 2 commits into from
Jan 8, 2025
Merged

SciPy 1.15 compatibility #1544

merged 2 commits into from
Jan 8, 2025

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jan 8, 2025

Some tests were incompatible with the recently release scipy==1.15. Fixed here.

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.93%. Comparing base (3f77252) to head (0829584).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1544      +/-   ##
===========================================
- Coverage    82.45%   79.93%   -2.53%     
===========================================
  Files          163      163              
  Lines        14034    14034              
===========================================
- Hits         11572    11218     -354     
- Misses        2462     2816     +354     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Some tests were incompatible with the recently release `scipy==1.15`. Fixed here.
PaulJonasJost added a commit that referenced this pull request Jan 8, 2025
@dweindl dweindl marked this pull request as ready for review January 8, 2025 10:22
Copy link
Collaborator

@PaulJonasJost PaulJonasJost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏🏼

@dweindl dweindl merged commit e31852b into ICB-DCM:develop Jan 8, 2025
17 of 18 checks passed
@dweindl dweindl deleted the fix_scipy branch January 8, 2025 10:25
github-merge-queue bot pushed a commit that referenced this pull request Jan 13, 2025
* Updated Changelog and Version

* Correct intendation

* Added #1544 to changelog preemtively as it needs to be merged before release anyways

* Updated recent pushs

* Updated changelod for recent pushes

* Forgot to mention one PR with #

* Correct intendation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants