Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: don't cache amici; pytest ignore amici_models; passenv BNGPATH #1523

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 27, 2024

  • Don't cache the amici installation. We are using amici/develop on purpose to detect problems early on. E.g., test_deepcopy_objective fails #1520 should have been detected much earlier.
  • Ignore amici_models when collecting tests
  • Use external BNGPATH if set

@dweindl dweindl self-assigned this Nov 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.79%. Comparing base (6eb4245) to head (b647f53).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1523      +/-   ##
===========================================
- Coverage    82.83%   82.79%   -0.04%     
===========================================
  Files          163      163              
  Lines        13962    13962              
===========================================
- Hits         11565    11560       -5     
- Misses        2397     2402       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Don't cache the amici installation.
  We are using amici/develop on purpose to detect problems early on. E.g., ICB-DCM#1520 should have been detected much earlier.
* Ignore `amici_models` when collecting tests
* Use external BNGPATH if set
@dweindl dweindl marked this pull request as ready for review November 27, 2024 08:53
@dweindl dweindl enabled auto-merge November 27, 2024 09:08
Copy link
Collaborator

@PaulJonasJost PaulJonasJost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do we need a BNGPATH for? It is for bionetgen but I am not entirely aware here we use it.

Independent, should be a good improvement, thanks 👍🏼

@dweindl dweindl added this pull request to the merge queue Nov 27, 2024
@dweindl
Copy link
Member Author

dweindl commented Nov 27, 2024

What do we need a BNGPATH for? It is for bionetgen but I am not entirely aware here we use it.

Yes, for BioNetGen, which is used by pysb.

Also used here:

# In CI, bionetgen is installed here
BNGPATH = os.path.abspath(
os.path.join(os.path.dirname(__file__), "..", "..", "BioNetGen-2.8.5")
)
if "BNGPATH" not in os.environ:
logging.warning(f"Env var BNGPATH was not set. Setting to {BNGPATH}")
os.environ["BNGPATH"] = BNGPATH

Merged via the queue into ICB-DCM:develop with commit d39b959 Nov 27, 2024
18 checks passed
@dweindl dweindl deleted the ci_amici_nocache branch November 27, 2024 10:59
This was referenced Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants