Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hierarchical: fix no error if inner observable parameter in noise formula & viceversa #1504

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

Doresic
Copy link
Contributor

@Doresic Doresic commented Nov 11, 2024

If an inner observable parameter was present in the noise formula, there was no error, even though that's not compatible with hierarchical optimization. This was caused by not searching for observable placeholders, overrides, and inner parameters in noise formulas and vice versa.

@Doresic Doresic changed the base branch from main to develop November 11, 2024 13:30
@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 60.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.82%. Comparing base (d5eedc2) to head (05cd6bd).

Files with missing lines Patch % Lines
pypesto/hierarchical/petab.py 60.00% 8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1504      +/-   ##
===========================================
+ Coverage    82.77%   82.82%   +0.05%     
===========================================
  Files          163      163              
  Lines        13907    13914       +7     
===========================================
+ Hits         11511    11524      +13     
+ Misses        2396     2390       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Doresic Doresic added this pull request to the merge queue Nov 12, 2024
Merged via the queue into develop with commit 80a7b8d Nov 12, 2024
18 checks passed
@Doresic Doresic deleted the hierarchical_fix_obs_pars_in_noise branch November 12, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants