ESSOptimizer: Fix priority for local search startpoints

[dweindl]

Fixes a bug in ESSOptimizer that lead to incorrect priorities for the selection of candidate solutions for local searches. A numpy array was incorrectly initialized from a generator, which led to the balance hyperparameter being practically ignored, and candidate solutions being ranked only by objective function value.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.69%. Comparing base (a82e637) to head (6ed8e0c).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1503      +/-   ##
===========================================
- Coverage    82.72%   82.69%   -0.03%     
===========================================
  Files          163      163              
  Lines        13896    13896              
===========================================
- Hits         11495    11491       -4     
- Misses        2401     2405       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Doresic]

Looks good, thanks!

So it's better to use from_iter in cases when we want to use the output as a numpy array rather than a generator? Because generators sometimes mess up as they don't behave like numpy arrays in all cases?

[dweindl]

So it's better to use from_iter in cases when we want to use the output as a numpy array rather than a generator? Because generators sometimes mess up as they don't behave like numpy arrays in all cases?

Not just better, but necessary. numpy.array(some_generator) will not execute the generator, but store it as such. Not only generators, but all iterators.