Hierarchical: avoid recomputing inner parameters if simulation failed #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dilpath
requested review from
PaulJonasJost,
dweindl and
FFroehlich
as code owners
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1426 +/- ##
========================================
Coverage 83.33% 83.34%
========================================
Files 161 161
Lines 13235 13237 +2
========================================
+ Hits 11030 11032 +2
Misses 2205 2205 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
result.x = Noneif simulation fails at the startpoint.result.xis used to compute hierarchical inner parameters after optimization. Whenresult.x = None, an AMICI simulation to compute inner parameters is still run, unexpectedly... I didn't look deeper there, but this PR stops the computation of inner parameters if simulation fails at the startpoint (defined byresult.x = None).This PR means users do not see
NaN in pAMICI simulation errors due toresult.x = None. This can be confusing for users, who then try (and fail) to reproduce those errors withobjective(result.x0).