Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select: support user-provided calibration results #1338

Merged
merged 12 commits into from
Nov 11, 2024

Conversation

dilpath
Copy link
Member

@dilpath dilpath commented Mar 26, 2024

Currently, the design is that:

  • a user can provide previously-calibrated models as user_calibrated_models
  • the design of PEtab Select was changed to accommodate this. A model selection iteration now involves two stages: "calibration" and "post-calibration". pyPESTO will not see the user-provided calibration results until the "post-calibration" stage of each iteration.
  • PEtab Select will put these models into the candidate space, instead of the uncalibrated versions
  • pyPESTO still needs to skip these models

The purpose is that the path through model space is still reproducible, because models are not skipped.
TODO: fully handle this in PEtab Select, so pyPESTO never sees already-calibrated models, except when it asks PEtab Select for the final results.

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.71%. Comparing base (d5eedc2) to head (0fdfae0).

Files with missing lines Patch % Lines
pypesto/select/method.py 86.66% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1338      +/-   ##
===========================================
- Coverage    82.77%   82.71%   -0.06%     
===========================================
  Files          163      163              
  Lines        13907    13910       +3     
===========================================
- Hits         11511    11506       -5     
- Misses        2396     2404       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@PaulJonasJost PaulJonasJost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 Is the functionality provided in petab select already?

Copy link
Contributor

@Doresic Doresic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature, thanks!

@dilpath dilpath requested a review from vwiela as a code owner November 6, 2024 10:11
@dilpath
Copy link
Member Author

dilpath commented Nov 11, 2024

Now handled on the PEtab Select side

@dilpath dilpath added this pull request to the merge queue Nov 11, 2024
Merged via the queue into develop with commit 9a69f3c Nov 11, 2024
18 checks passed
@dilpath dilpath deleted the select_use_old_calibrations branch November 12, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants