-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select: support user-provided calibration results #1338
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1338 +/- ##
===========================================
- Coverage 82.77% 82.71% -0.06%
===========================================
Files 163 163
Lines 13907 13910 +3
===========================================
- Hits 11511 11506 -5
- Misses 2396 2404 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼 Is the functionality provided in petab select already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice feature, thanks!
Now handled on the PEtab Select side |
Currently, the design is that:
user_calibrated_models
PEtab Select will put these models into the candidate space, instead of the uncalibrated versionspyPESTO still needs to skip these modelsThe purpose is that the path through model space is still reproducible, because models are not skipped.
TODO: fully handle this in PEtab Select, so pyPESTO never sees already-calibrated models, except when it asks PEtab Select for the final results.