-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruff codechecks #1307
Ruff codechecks #1307
Conversation
… from pre-commits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Mostly looks good.
Looks good to me. Would remove .flake8. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1307 +/- ##
============================================
- Coverage 84.27% 53.32% -30.96%
============================================
Files 153 153
Lines 12459 12456 -3
============================================
- Hits 10500 6642 -3858
- Misses 1959 5814 +3855 ☔ View full report in Codecov by Sentry. |
bit late now, but might make sense to add the PR of this commit to a |
might make sense to include yanks black changes back then as well 🤔 |
Most important to check would be
can flake8 be deleted from tox and .flake8 as well?