Cleanup pypesto/profile/profile_next_guess.py

[dweindl]

Some cleanup / simplification of pypesto/profile/profile_next_guess.py

[codecov-commenter]

Codecov Report

Merging #1167 (ba129d4) into develop (160c2a8) will decrease coverage by 3.78%.
Report is 408 commits behind head on develop.
The diff coverage is 87.87%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop    #1167      +/-   ##
===========================================
- Coverage    88.16%   84.39%   -3.78%     
===========================================
  Files           79      148      +69     
  Lines         5257    11667    +6410     
===========================================
+ Hits          4635     9846    +5211     
- Misses         622     1821    +1199     

Files	Coverage Δ
pypesto/C.py	100.00% <100.00%> (ø)
pypesto/__init__.py	100.00% <100.00%> (ø)
pypesto/engine/__init__.py	100.00% <100.00%> (ø)
pypesto/engine/multi_process.py	93.10% <100.00%> (+0.79%)	⬆️
pypesto/engine/multi_thread.py	100.00% <100.00%> (ø)
pypesto/engine/single_core.py	100.00% <100.00%> (ø)
pypesto/engine/task.py	100.00% <100.00%> (ø)
pypesto/ensemble/__init__.py	100.00% <100.00%> (ø)
pypesto/ensemble/task.py	100.00% <100.00%> (ø)
pypesto/hierarchical/__init__.py	100.00% <100.00%> (ø)
... and 138 more

[PaulJonasJost]

Thanks for the cleanup. If we remove the increase line search, perhaps we should also change the Literal/remove it? But not quite sure whether it is not used somewhere else.

[PaulJonasJost]

I know that it technically makes no difference, but elif would highlight more, that these comparisons belong to each other wouldn't it?

[dweindl]

Do they really belong together? I'd say no. Fixed step: we are good to go. Adaptive step; we need to set order. I think this makes it clearer.

[PaulJonasJost]

one can argue like that as well. No strong preference here 👍🏼

[dweindl]

If we remove the increase line search,

It's still there! See other comment.