Fix pypesto.profile.parameter_profile incorrectly assuming symmetric bounds #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bounds Use the correct bounds for checking whether we are done computing the profile. Add test. Closes #1165
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #1166 +/- ##
============================================
- Coverage 88.16% 53.37% -34.80%
============================================
Files 79 148 +69
Lines 5257 11653 +6396
============================================
+ Hits 4635 6220 +1585
- Misses 622 5433 +4811
|
PaulJonasJost
approved these changes
Oct 30, 2023
| ) or (current_profile.ratio_path[-1] < options.ratio_min) | ||
| raise AssertionError("par_direction must be -1 or 1") | ||
| if not options.whole_path: | ||
| stop_profile |= current_profile.ratio_path[-1] < options.ratio_min |
There was a problem hiding this comment.
not entirely sure why not an = but should be fine.
There was a problem hiding this comment.
Because it's stop_due_to_bounds or stop_due_to_ratio, just = would ignore the stop_due_to_bounds part.
This was referenced Nov 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the correct bounds for checking whether we are done computing the profile.
Add test.
Closes #1165