Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProfileOptions: add some basic integrity checking #1163

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Oct 30, 2023

I kept wondering why changing min_step_size did not change anything. Turned out it was nowhere checked whether default_step_size is below min_step_size...

Now ProfileOptions.__init__ and pypesto.profile.parameter_profile check at least a subset of profiling options.

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

Merging #1163 (12fe21d) into develop (160c2a8) will decrease coverage by 3.78%.
Report is 405 commits behind head on develop.
The diff coverage is 87.95%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop    #1163      +/-   ##
===========================================
- Coverage    88.16%   84.39%   -3.78%     
===========================================
  Files           79      148      +69     
  Lines         5257    11666    +6409     
===========================================
+ Hits          4635     9845    +5210     
- Misses         622     1821    +1199     
Files Coverage Δ
pypesto/C.py 100.00% <100.00%> (ø)
pypesto/__init__.py 100.00% <100.00%> (ø)
pypesto/engine/__init__.py 100.00% <100.00%> (ø)
pypesto/engine/multi_process.py 93.10% <100.00%> (+0.79%) ⬆️
pypesto/engine/multi_thread.py 100.00% <100.00%> (ø)
pypesto/engine/single_core.py 100.00% <100.00%> (ø)
pypesto/engine/task.py 100.00% <100.00%> (ø)
pypesto/ensemble/__init__.py 100.00% <100.00%> (ø)
pypesto/ensemble/task.py 100.00% <100.00%> (ø)
pypesto/hierarchical/__init__.py 100.00% <100.00%> (ø)
... and 138 more

Copy link
Collaborator

@PaulJonasJost PaulJonasJost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test as well 👍🏼

@dweindl dweindl merged commit 8d3986d into develop Oct 30, 2023
17 checks passed
@dweindl dweindl deleted the profileopts_validate branch October 30, 2023 19:30
This was referenced Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants