Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/forward startpoint_kwargs in PetabImporter.create_problem #1135

Merged
merged 6 commits into from
Oct 23, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Oct 13, 2023

Simplifies combining PEtab startpoint sampling with checked sampling (i.e. resample in case of non-finite fvals/gradients), e.g.:

problem = importer.create_problem(
    startpoint_kwargs=dict(check_fval=True, check_grad=True)
)

Closes #1119

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

Merging #1135 (58b832b) into develop (883138a) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop    #1135      +/-   ##
===========================================
- Coverage    84.43%   84.31%   -0.12%     
===========================================
  Files          148      148              
  Lines        11642    11644       +2     
===========================================
- Hits          9830     9818      -12     
- Misses        1812     1826      +14     
Files Coverage Δ
pypesto/petab/importer.py 89.92% <100.00%> (+0.07%) ⬆️

... and 6 files with indirect coverage changes

@dweindl dweindl marked this pull request as ready for review October 16, 2023 08:24
@dweindl dweindl requested a review from FFroehlich as a code owner October 16, 2023 08:24
Copy link
Collaborator

@PaulJonasJost PaulJonasJost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

Copy link
Contributor

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dweindl dweindl merged commit 74c526e into develop Oct 23, 2023
17 checks passed
@dweindl dweindl deleted the startpoint_kwargs branch October 23, 2023 06:07
This was referenced Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants