Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ensembles from optimization endpoints #1130

Merged
merged 4 commits into from
Oct 11, 2023
Merged

fix ensembles from optimization endpoints #1130

merged 4 commits into from
Oct 11, 2023

Conversation

plakrisenko
Copy link
Member

If only the names of free parameters are taken https://github.com/ICB-DCM/pyPESTO/blob/main/pypesto/ensemble/ensemble.py#L663,
then maybe the same should be true for the parameter values

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2023

Codecov Report

Merging #1130 (96f25d1) into develop (160c2a8) will decrease coverage by 3.79%.
Report is 387 commits behind head on develop.
The diff coverage is 87.95%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop    #1130      +/-   ##
===========================================
- Coverage    88.16%   84.38%   -3.79%     
===========================================
  Files           79      148      +69     
  Lines         5257    11642    +6385     
===========================================
+ Hits          4635     9824    +5189     
- Misses         622     1818    +1196     
Files Coverage Δ
pypesto/C.py 100.00% <100.00%> (ø)
pypesto/__init__.py 100.00% <100.00%> (ø)
pypesto/engine/__init__.py 100.00% <100.00%> (ø)
pypesto/engine/multi_process.py 100.00% <100.00%> (+7.69%) ⬆️
pypesto/engine/multi_thread.py 100.00% <100.00%> (ø)
pypesto/engine/single_core.py 100.00% <100.00%> (ø)
pypesto/engine/task.py 100.00% <100.00%> (ø)
pypesto/ensemble/__init__.py 100.00% <100.00%> (ø)
pypesto/ensemble/task.py 100.00% <100.00%> (ø)
pypesto/hierarchical/__init__.py 100.00% <100.00%> (ø)
... and 138 more

Copy link
Contributor

@vwiela vwiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue of getting constant predictions.

Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dilpath
Copy link
Member

dilpath commented Oct 10, 2023

@PaulJonasJost is this an issue in Ensemble.from_optimization_history too?

@plakrisenko plakrisenko merged commit 4c25569 into develop Oct 11, 2023
17 checks passed
@PaulJonasJost PaulJonasJost mentioned this pull request Oct 11, 2023
@PaulJonasJost PaulJonasJost deleted the ensemble_fix branch October 24, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants