Select: support version 0.1.8 (#1070)

* set predecessor manually in multistart selection
ICB-DCM · May 31, 2023 · 7b27ccd · 7b27ccd
1 parent 7d49422
commit 7b27ccd
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/pypesto/select/method.py b/pypesto/select/method.py
@@ -364,10 +364,6 @@ def __call__(
             calibrated_models=self.calibrated_models,
             newly_calibrated_models=newly_calibrated_models,
             excluded_model_hashes=self.calibrated_models.keys(),
-            # FIXME meaning changes here, i.e. predecessor model is used as previous
-            #       predecessor model, since PEtab Select now gets the next predecessor
-            #       model if the candidate space has models.
-            previous_predecessor_model=predecessor_model,
             criterion=self.criterion,
         )
         predecessor_model = self.candidate_space.predecessor_model

diff --git a/pypesto/select/problem.py b/pypesto/select/problem.py
@@ -242,6 +242,9 @@ def multistart_select(
 
         method_caller = self.create_method_caller(**kwargs)
         for start_index, predecessor_model in enumerate(predecessor_models):
+            method_caller.candidate_space.previous_predecessor_model = (
+                predecessor_model
+            )
             (
                 best_model,
                 newly_calibrated_models_list[start_index],

diff --git a/setup.cfg b/setup.cfg
@@ -151,7 +151,7 @@ select =
     # Remove when vis is moved to PEtab Select version
     networkx >= 2.5.1
     # End remove
-    petab-select >= 0.1.1
+    petab-select >= 0.1.8
 test =
     pytest >= 5.4.3
     pytest-cov >= 2.10.0