Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable http generate endpoint #22

Closed

Conversation

dtrifiro
Copy link
Collaborator

How Has This Been Tested?

Spin up text generations server:

text-generation-launcher --model-name ./flan-t5-small

Using curl

curl --header "Content-Type: application/json"  --data '{"inputs": "complete this text"}' localhost:3000/generate

Result:

[{"generated_text":"a sluggish sluggish sluggish sl"}]

Using httpie

Hit the server using httpie:

http :3000/generate inputs="complete this text"

Result:

HTTP/1.1 200 OK
content-length: 54
content-type: application/json
date: Tue, 09 Jan 2024 16:01:31 GMT
x-inference-time: 175
x-queue-time: 0
x-time-per-token: 8
x-total-time: 175
x-validation-time: 0

[
    {
        "generated_text": "a sluggish sluggish sluggish sl"
    }
]

@dtrifiro dtrifiro force-pushed the enable-http-generate-endpoint-ibm branch 2 times, most recently from 9def240 to a6c25c4 Compare January 12, 2024 16:36
@dtrifiro
Copy link
Collaborator Author

@njhill I quickly tested this as mentioned above and it seems to be working. Is there any additional context regarding why this endpoint was disabled?

@dtrifiro dtrifiro force-pushed the enable-http-generate-endpoint-ibm branch from a6c25c4 to b915aa0 Compare January 23, 2024 10:14
@dtrifiro dtrifiro force-pushed the enable-http-generate-endpoint-ibm branch 2 times, most recently from 54fda5e to 3ebb3db Compare February 1, 2024 11:38
@dtrifiro dtrifiro force-pushed the enable-http-generate-endpoint-ibm branch from 3ebb3db to 9fb15e8 Compare February 13, 2024 11:39
@joerunde
Copy link
Collaborator

Needs more discussion with @njhill

@dtrifiro dtrifiro force-pushed the enable-http-generate-endpoint-ibm branch from 9fb15e8 to a4ead6b Compare March 4, 2024 10:19
Signed-off-by: Daniele Trifirò <dtrifiro@redhat.com>
@dtrifiro dtrifiro force-pushed the enable-http-generate-endpoint-ibm branch from a4ead6b to 8b10d79 Compare March 13, 2024 14:30
@dtrifiro dtrifiro marked this pull request as draft March 26, 2024 08:59
@dtrifiro dtrifiro closed this Jun 20, 2024
Xaenalt pushed a commit to Xaenalt/text-generation-inference that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants