Merge pull request #32 from IBM/deprecate

BREAKING CHANGE: deprecating NotificationsAPI
IBM · Dec 20, 2021 · a9bd032 · a9bd032
2 parents 1c23c32 + b0913cf
commit a9bd032
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 3,031 deletions.
diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml
@@ -57,7 +57,6 @@ jobs:
         env:
           ACCOUNT_ID: ${{ secrets.ACCOUNT_ID }}
           FINDINGS_ENV: ${{ secrets.FINDINGS_ENV }}
-          NOTIFICATIONS_ENV: ${{ secrets.NOTIFICATIONS_ENV }}
           CONFIGURATION_GOVERNANCE_ENV: ${{ secrets.CONFIGURATION_GOVERNANCE_ENV }}
           RESOURCE_GROUP_ID: ${{ secrets.RESOURCE_GROUP_ID }}
         run: build/testScript.sh

diff --git a/README.md b/README.md
@@ -48,7 +48,6 @@ IBM Cloud services:
 Service Name | Module Name | Imported Class Name
 --- | --- | ---
 [Findings](https://cloud.ibm.com/apidocs/security-compliance/findings) | findings_v1 | FindingsV1
-[Notifications](https://cloud.ibm.com/apidocs/security-compliance/si-notifications) | notifications_v1 | NotificationsV1
 [Configuration Governance](https://cloud.ibm.com/apidocs/security-compliance/config) | configuration_governance_v1 | ConfigurationGovernanceV1
 
 ## Prerequisites

diff --git a/build/testScript.sh b/build/testScript.sh
@@ -4,6 +4,5 @@ set -euo pipefail
 
 curl https://us-south.functions.appdomain.cloud/api/v1/web/e6b54af6-ab44-4149-a8e4-e906dcc58136/default/secadvstg-location-shift.json
 echo "${FINDINGS_ENV}" | base64 -d >> findings_v1.env
-echo "${NOTIFICATIONS_ENV}" | base64 -d >> notifications_v1.env
 echo "${CONFIGURATION_GOVERNANCE_ENV}" | base64 -d >> configuration_governance_v1.env
 python -m pytest test/integration