Encode spaces in parameter values for oauth-1.0a #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a simple test of tweets/search/recent with access keys along the lines of what is done for consumer keys. It currently fails with a 401 exception. See HunterLarco#90 for details.
This commit fixes HunterLarco#90 by making sure that spaces in URLs are encoded using %20 instead +. While technically correct the underlying oauth-1.0a library will encode a + as %2B when signing, which causes an 401 Authentication error, because the URL that was signed was not the URL that was fetched. The fix isn't particulary satisfying, but it does pass the tests except for `should stream data without any rules` which was already failing.
This is a build so I can npm install from GitHub until this HunterLarco#90 is fixed.
|
Thanks! 😄 Waiting for this fix. |
1 task
|
I just wanna get twitter username in streaming, someone has a code that´s show how get that? const endpointParameters = { So in listenForever the |
|
Needed this - thanks @edsu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #90 by making sure that spaces in URLs are encoded using %20 instead +. While technically correct the underlying oauth-1.0a library will encode a + as %2B when signing, which causes an 401 Authentication error, because the URL that was signed was not the URL that was fetched.
The fix isn't particularly satisfying, but it does pass the tests except for
should stream data without any ruleswhich was already failing.