Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DIA-1839: Add JWT auth for API tokens #6996

Merged
merged 70 commits into from
Feb 12, 2025
Merged

feat: DIA-1839: Add JWT auth for API tokens #6996

merged 70 commits into from
Feb 12, 2025

Conversation

pakelley
Copy link
Contributor

@pakelley pakelley commented Jan 29, 2025

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

(link to issue, supportive screenshots etc.)

What does this fix?

(if this is a bug fix)

What is the new behavior?

(if this is a breaking or feature change)

What is the current behavior?

(if this is a breaking or feature change)

What libraries were added/updated?

(list all with version changes)

Does this change affect performance?

(if so describe the impacts positive or negative)

Does this change affect security?

(if so describe the impacts positive or negative)

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

@github-actions github-actions bot added the feat label Jan 29, 2025
Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 14f74c4
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/67abd9d8d5462d0008acc0a7

Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 14f74c4
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/67abd9d8b947690008e690ac

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 85.50000% with 29 lines in your changes missing coverage. Please review.

Project coverage is 77.06%. Comparing base (9ce70d7) to head (14f74c4).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
label_studio/jwt_auth/views.py 69.44% 22 Missing ⚠️
label_studio/jwt_auth/models.py 93.18% 3 Missing ⚠️
label_studio/jwt_auth/middleware.py 93.10% 2 Missing ⚠️
label_studio/jwt_auth/serializers.py 90.47% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6996      +/-   ##
===========================================
+ Coverage    76.95%   77.06%   +0.11%     
===========================================
  Files          175      183       +8     
  Lines        14187    14387     +200     
===========================================
+ Hits         10917    11088     +171     
- Misses        3270     3299      +29     
Flag Coverage Δ
pytests 77.06% <85.50%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pakelley
Copy link
Contributor Author

pakelley commented Feb 1, 2025

/git merge develop

Workflow run
Successfully merged: create mode 100644 label_studio/ml_models/migrations/0014_alter_thirdpartymodelversion_provider.py

@pakelley
Copy link
Contributor Author

pakelley commented Feb 11, 2025

/git merge develop

Workflow run
Successfully merged: rename web/libs/editor/tests/integration/e2e/{video_segmentation => video}/regions.cy.ts (100%)

@pakelley pakelley merged commit 748611e into develop Feb 12, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants