feat: LEAP-1709: Add region index displaying to relations list #6941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new region index element in the details panel with corresponding styles for alignment and visibility. Updated margin and layout adjustments for consistent design across elements. Introduced gap styling in relations panel for better spacing of node elements.
Region indices are now set consistently during sorting and creation. Removed redundant region index assignment in OutlinerTree to avoid discrepancies.
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
Refactored region index updates to a dedicated method `updateIndexes` for better consistency and maintainability. This ensures indexes are recalculated correctly after sorting, creation, or deletion of regions. Resolved a problem causing crashes due to observer side effects.
Gondragos
changed the title
Gondragos
force-pushed
the
fb-leap-1709/region-index-in-relations
branch
from
e73d107 to
66e8b69
Compare
Added new utility methods for handling regions, labels, and localStorage in LSF helpers. Introduced customizable callbacks for `init` and improved functionality for ordering and deleting regions in the Sidebar.
Replaced `setRegionIndex` logic with a computed `region_index` derived from a new `regionIndexMap`. Add some new triggers for updateAppearenceFromState.
Gondragos
force-pushed
the
fb-leap-1709/region-index-in-relations
branch
from
66e8b69 to
1a87c42
Compare
Removed redundant updateIndexes calls and adjusted region_index getter to handle non-real regions properly. This improves performance and prevents errors related to invalid indexing.
Ensure localStorage values are correctly serialized only when necessary. This prevents potential issues when dealing with string data types.
Add integration test to verify region list consistency when regions are deleted or created. This includes handling changes affecting the entire list and ensuring correct relabeling and ordering.
|
/git merge develop
|
bmartel
approved these changes
Jan 28, 2025
Co-authored-by: bmartel <brandonmartel@gmail.com>
|
/git merge develop
|
Previously, annotation appearance updates were missing during certain interactions. This fix ensures `updateAppearenceFromState` is called after sorting or grouping regions. Added an integration test to verify label consistency when changing order.
….com/heartexlabs/label-studio into fb-leap-1709/region-index-in-relations
Ensure `updateAppearenceFromState` is called only if `annotation` is defined. This prevents runtime errors during the destruction phase.
|
/git merge develop
|
|
/git merge develop
|
…ations' into fb-leap-1709/region-index-in-relations
hlomzik
approved these changes
Jan 31, 2025
|
/git merge develop
|
|
/git merge develop
|
|
/git merge develop
|
MihajloHoma
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)
Describe the reason for change
What is the new behavior?
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
Relations Panel,region_index