Skip to content

Commit

Permalink
Fix Github Workflows for Release (open-metadata#16224)
Browse files Browse the repository at this point in the history
  • Loading branch information
IceS2 authored May 10, 2024
1 parent 0e2736e commit a4e410b
Show file tree
Hide file tree
Showing 8 changed files with 26 additions and 8 deletions.
16 changes: 11 additions & 5 deletions .github/actions/prepare-for-docker-build-and-push/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@ inputs:
description: true if we are building an Ingestion image, false otherwise
required: true
default: "false"
dockerhub_username:
description: Dockerhub Username
required: true
dockerhub_token:
description: Dockerhub Token
required: true

outputs:
tags:
Expand All @@ -34,17 +40,17 @@ runs:
- name: Login to DockerHub
uses: docker/login-action@v2
with:
username: ${{ secrets.DOCKERHUB_OPENMETADATA_USERNAME }}
password: ${{ secrets.DOCKERHUB_OPENMETADATA_TOKEN }}
username: ${{ inputs.dockerhub_username }}
password: ${{ inputs.dockerhub_token }}

- name: Install Ubuntu dependencies
if: ${{ inputs.is_ingestion == "true" }}
if: inputs.is_ingestion == true
shell: bash
run: |
sudo apt-get install -y python3-venv
- name: Install open-metadata dependencies
if: ${{ inputs.is_ingestion == "true" }}
if: inputs.is_ingestion == true
shell: bash
run: |
python3 -m venv env
Expand All @@ -57,7 +63,7 @@ runs:
id: generate-tags
shell: bash
run: |
if ${{ inputs.push_latest == "true" }}; then
if ${{ inputs.push_latest == 'true' }}; then
echo "tags=${{ inputs.image }}:${{ inputs.tag }},${{ inputs.image }}:latest" >> $GITHUB_OUTPUT
else
echo "tags=${{ inputs.image }}:${{ inputs.tag }}" >> $GITHUB_OUTPUT
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/docker-openmetadata-db.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ jobs:
image: openmetadata/db
tag: ${{ inputs.tag }}
push_latest: ${{ inputs.push_latest_tag_to_release }}
dockerhub_username: ${{ secrets.DOCKERHUB_OPENMETADATA_USERNAME }}
dockerhub_token: ${{ secrets.DOCKERHUB_OPENMETADATA_TOKEN }}


- name: Build and push if event is workflow_dispatch and input is checked
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/docker-openmetadata-ingestion-base-slim.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ jobs:
tag: ${{ inputs.tag }}
push_latest: ${{ inputs.push_latest_tag_to_release }}
is_ingestion: true
dockerhub_username: ${{ secrets.DOCKERHUB_OPENMETADATA_USERNAME }}
dockerhub_token: ${{ secrets.DOCKERHUB_OPENMETADATA_TOKEN }}

- name: Build and push if event is workflow_dispatch and input is checked
uses: docker/build-push-action@v3
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/docker-openmetadata-ingestion-base.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ jobs:
tag: ${{ inputs.tag }}
push_latest: ${{ inputs.push_latest_tag_to_release }}
is_ingestion: true
dockerhub_username: ${{ secrets.DOCKERHUB_OPENMETADATA_USERNAME }}
dockerhub_token: ${{ secrets.DOCKERHUB_OPENMETADATA_TOKEN }}

- name: Build and push if event is workflow_dispatch and input is checked
uses: docker/build-push-action@v3
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/docker-openmetadata-ingestion.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ jobs:
tag: ${{ inputs.tag }}
push_latest: ${{ inputs.push_latest_tag_to_release }}
is_ingestion: true
dockerhub_username: ${{ secrets.DOCKERHUB_OPENMETADATA_USERNAME }}
dockerhub_token: ${{ secrets.DOCKERHUB_OPENMETADATA_TOKEN }}

- name: Build and push if event is workflow_dispatch and input is checked
uses: docker/build-push-action@v3
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/docker-openmetadata-postgres.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ jobs:
with:
image: openmetadata/postgresql
tag: ${{ inputs.tag }}
push_latest: ${{ inputs.push_latest_tag_to_release }}
push_latest: ${{ inputs.p
dockerhub_username: ${{ secrets.DOCKERHUB_OPENMETADATA_USERNAME }}
dockerhub_token: ${{ secrets.DOCKERHUB_OPENMETADATA_TOKEN }}ush_latest_tag_to_release }}

- name: Build and push if event is workflow_dispatch and input is checked
uses: docker/build-push-action@v3
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/docker-openmetadata-server.yml
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,9 @@ jobs:
with:
image: openmetadata/server
tag: ${{ inputs.DOCKER_RELEASE_TAG }}
push_latest: ${{ inputs.push_latest_tag_to_release }}
push_latest: ${{ inputs.push_
dockerhub_username: ${{ secrets.DOCKERHUB_OPENMETADATA_USERNAME }}
dockerhub_token: ${{ secrets.DOCKERHUB_OPENMETADATA_TOKEN }}latest_tag_to_release }}

- name: Build and push if event is workflow_dispatch and input is checked
uses: docker/build-push-action@v3
Expand Down
2 changes: 1 addition & 1 deletion scripts/update_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def update_dockerfile_arg(arg, file_path, value):
regex_sub(
file_path,
rf"(ARG\s+{arg}=).+",
rf"\1={value}",
rf'\1"{value}"',

)

Expand Down

0 comments on commit a4e410b

Please sign in to comment.