Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goplus: test fix #207513

Merged
merged 1 commit into from
Feb 14, 2025
Merged

goplus: test fix #207513

merged 1 commit into from
Feb 14, 2025

Conversation

stefanb
Copy link
Member

@stefanb stefanb commented Feb 13, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Test failure noticed in

but pinning to go1.23 made no difference.

Not sure why it passed in previous runs on same version

Not the first upstream stdout/stderr inconsistency / wierdness:

@github-actions github-actions bot added the go Go use is a significant feature of the PR or issue label Feb 13, 2025
@stefanb stefanb force-pushed the goplus-revision-bump-go-1.24 branch from c691c2d to 7704b22 Compare February 13, 2025 06:27
@stefanb stefanb changed the title goplus: revision bump (go 1.24) goplus: pin to go@1.23 (go 1.24) Feb 13, 2025
@stefanb stefanb force-pushed the goplus-revision-bump-go-1.24 branch from 7704b22 to 4167aec Compare February 14, 2025 07:15
@stefanb stefanb changed the title goplus: pin to go@1.23 (go 1.24) goplus: test fix Feb 14, 2025
@stefanb stefanb force-pushed the goplus-revision-bump-go-1.24 branch from 4167aec to 9e094fa Compare February 14, 2025 07:24
@stefanb stefanb marked this pull request as ready for review February 14, 2025 07:30
@stefanb stefanb added CI-no-bottles Merge without publishing bottles ready to merge PR can be merged once CI is green labels Feb 14, 2025
@BrewTestBot BrewTestBot added this pull request to the merge queue Feb 14, 2025
Merged via the queue into master with commit 3f89112 Feb 14, 2025
23 checks passed
@BrewTestBot BrewTestBot deleted the goplus-revision-bump-go-1.24 branch February 14, 2025 12:02
@stefanb stefanb restored the goplus-revision-bump-go-1.24 branch February 18, 2025 19:48
@stefanb stefanb deleted the goplus-revision-bump-go-1.24 branch February 18, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles go Go use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants